New issue
Advanced search Search tips

Issue 657941 link

Starred by 2 users
Status: Verified
Owner:
steve...@chromium.org
Closed: Dec 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 614589



Sign in to add a comment

Display settings: Incorrect resolutions shown for second monitor

Project Member Reported by michae...@chromium.org, Oct 20 2016 
Chrome 55.0.2878.0, samus

1. Have external monitor
2. Open chrome://md-settings => Displays
3. Tap external display
4. Tap internal display

Expected: nothing happens besides changing selection
Actual: both screens flash off and on, and the page errors (possibly unrelated):

display.js:225 Uncaught TypeError: Cannot read property 'uiScale' of undefined
    at HTMLElement.getResolutionText_ (display.js:225)
    at HTMLElement._annotatedComputationEffect (polymer-extracted.js:1622)
    at HTMLElement._effectEffects (polymer-extracted.js:1429)
    at HTMLElement._propertySetter (polymer-extracted.js:1413)
    at HTMLElement.setter (polymer-extracted.js:1492)
    at HTMLElement.onSelectDisplay_ (display.js:244)
    at HTMLElement.handler (polymer-extracted.js:499)
    at HTMLElement.fire (polymer-extracted.js:1267)
    at HTMLElement.onSelectDisplayTap_ (display_layout.js:186)
    at handler (polymer-extracted.js:499)

Comment 1 by michae...@chromium.org, Oct 20 2016

Summary: Display settings: Incorrect resolutions shown for second monitor (was: Display settings: Screen flicker and "Cannot read property 'uiScale' of undefined" error)
Moving screen flash to  issue 657944 .

One manifestation of this JS error is that the number of pips in the Resolution slider does not get updated when changing the selection from a display with more modes to a display with fewer modes, IF the display with more modes is set to a mode index higher than the internal display's mode index. You can then select slider positions that don't correspond to modes, causing the display to not change.

(In English: if you have two displays, the selected display has more resolutions, and both displays are at their native resolutions, then selecting the other display fails to update the slider pips.)

Comment 2 by michae...@chromium.org, Oct 20 2016

Blocking: 614589

Comment 3 by omrilio@chromium.org, Nov 1 2016

Status: Assigned (was: Untriaged)

Comment 4 by steve...@chromium.org, Dec 6 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3baff7a69c5c98558fa82dbced8307bc25714e

commit 7b3baff7a69c5c98558fa82dbced8307bc25714e
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Dec 07 00:35:14 2016

MD Settings: Display: Fix resolution text

BUG= 657941 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556773003
Cr-Commit-Position: refs/heads/master@{#436781}

[modify] https://crrev.com/7b3baff7a69c5c98558fa82dbced8307bc25714e/chrome/browser/resources/settings/device_page/display.js

Comment 6 by steve...@chromium.org, Dec 7 2016

Status: Fixed (was: Started)

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by abod...@chromium.org, Apr 5 2017

Status: Verified (was: Fixed)
Chrome OS 9433.0.0 59.0.3055.0
►

Sign in to add a comment