Linux downloads bar buttons are unreadable with a dark theme |
|||||||||||||
Issue descriptionLinux downloads bar buttons are unreadable with a dark theme On Ubuntu 14.04 LTS with Chrome 55.0.2883.18 (Official Build) dev (64-bit): 1) Apply a dark Chrome theme, eg: https://chrome.google.com/webstore/detail/marc-ecko/opjonmehjfmkejjifhhknofdnacklmjk?hl=en 2) Start a download that causes a prompt, eg: http://symless.com/download/file/?file=synergy-v1.8.4-stable-a6ff907-Linux-x86_64.deb Expected: User can read the buttons on the download bar prompt. Actual: Button text is illegible over the button images. See attached.
,
Oct 20 2016
,
Oct 20 2016
,
Oct 20 2016
thanks for reporting the bug. I'm pretty sure it's an issue that affects all versions of Chrome that are using the MD shelf, i.e. M54, M53, etc. The fix should be merged to m55 imo.
,
Oct 20 2016
actually, I don't think it affected earlier versions, just m55. See fix for show all here: https://codereview.chromium.org/2400563004
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9ac8cf058d18afc6ab23455560da81bc2154c35 commit c9ac8cf058d18afc6ab23455560da81bc2154c35 Author: estade <estade@chromium.org> Date: Fri Oct 21 17:29:39 2016 Make all text buttons on download shelf work well with themes, not just the "show all" button. BUG= 657935 Review-Url: https://chromiumcodereview.appspot.com/2439873002 Cr-Commit-Position: refs/heads/master@{#426828} [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35/ui/views/controls/button/md_text_button.h
,
Oct 21 2016
,
Oct 24 2016
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
,
Oct 24 2016
Before we approve merge to M55 branch 2883, could you please confirm whether this change is baked/verified in Canary and safe to merge to M55?
,
Oct 24 2016
,
Oct 24 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bc6477482d746d519bfa9c5ea0793d1de22d534 commit 0bc6477482d746d519bfa9c5ea0793d1de22d534 Author: Evan Stade <estade@chromium.org> Date: Mon Oct 24 20:56:46 2016 Make all text buttons on download shelf work well with themes, not just the "show all" button. BUG= 657935 Review-Url: https://chromiumcodereview.appspot.com/2439873002 Cr-Commit-Position: refs/heads/master@{#426828} (cherry picked from commit c9ac8cf058d18afc6ab23455560da81bc2154c35) Review URL: https://codereview.chromium.org/2451453002 . Cr-Commit-Position: refs/branch-heads/2883@{#260} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/ui/views/controls/button/md_text_button.h
,
Oct 24 2016
,
Oct 26 2016
Tested the same on Linux non corp machine using chrome beta version 55.0.2883.28 - Observed that the buttons "Keep" and "discard" displayed fine with the theme https://chrome.google.com/webstore/detail/marc-ecko/opjonmehjfmkejjifhhknofdnacklmjk?hl=en installed Please find the screenshot Windows behavior : The file gets downloaded without displaying the prompt on both corp and non corp machines estade@, Could you please let us know how to initiate the download prompt on windows
,
Oct 26 2016
you have to find a download that's considered dangerous on windows --- I think this one should work: http://download.safebrowsingtest.com/download/test?attredirects=0&d=1 (that will only show one button but it should be sufficient to make sure that one button looks as expected)
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bc6477482d746d519bfa9c5ea0793d1de22d534 commit 0bc6477482d746d519bfa9c5ea0793d1de22d534 Author: Evan Stade <estade@chromium.org> Date: Mon Oct 24 20:56:46 2016 Make all text buttons on download shelf work well with themes, not just the "show all" button. BUG= 657935 Review-Url: https://chromiumcodereview.appspot.com/2439873002 Cr-Commit-Position: refs/heads/master@{#426828} (cherry picked from commit c9ac8cf058d18afc6ab23455560da81bc2154c35) Review URL: https://codereview.chromium.org/2451453002 . Cr-Commit-Position: refs/branch-heads/2883@{#260} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/0bc6477482d746d519bfa9c5ea0793d1de22d534/ui/views/controls/button/md_text_button.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by msw@chromium.org
, Oct 20 2016Labels: -Pri-3 Pri-2