New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657934 link

Starred by 1 user
Status: Verified
Owner:
█ yoshiki@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ rookrishna@chromium.org
sdantul...@chromium.org
elijahtaylor@chromium.org
█ yoshiki@chromium.org
dhadd...@chromium.org
achuith@chromium.org
abod...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Notification center useless and noisy during supervised user creation (with ARC++ enabled)

Project Member Reported by dhadd...@chromium.org, Oct 20 2016 
M55 | 8872.18.0

1. Log in as regular user
2. opt in to ARC++
3. sign out
4. Create supervised user
5. enter regular users password
6. On the next screen you can see the notification center but can't open the notifications 
7. And you get "Did you just sign in?" spam

See screenshot
Screenshot 2016-10-20 at 10.55.53 AM.png
3.3 MB View Download

Comment 1 by dhadd...@chromium.org, Oct 20 2016

Cc: yoshiki@chromium.org

Comment 2 by uekawa@chromium.org, Oct 21 2016 

is this a dupe of internal bug b/31623361 ?

Comment 3 by yoshiki@chromium.org, Oct 21 2016

Owner: yoshiki@chromium.org
Status: Started (was: Untriaged)
Yes, they are the same bug.

Comment 4 by achuith@chromium.org, Nov 30 2016

Cc: achuith@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c172fcc9dd0a684ebddb3e288d063a5174fcee88

commit c172fcc9dd0a684ebddb3e288d063a5174fcee88
Author: yoshiki <yoshiki@chromium.org>
Date: Mon Dec 05 17:38:25 2016

Stop running arc container on supervised user creation flow

BUG= 657934 
TEST=Manually tested (enter supervised user creation flow, and confirm arc is not running)

Review-Url: https://codereview.chromium.org/2513473006
Cr-Commit-Position: refs/heads/master@{#436332}

[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_flow.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_flow.h
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.h
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.h
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/user_flow.cc
[modify] https://crrev.com/c172fcc9dd0a684ebddb3e288d063a5174fcee88/chrome/browser/chromeos/login/user_flow.h
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d276665acabcc6b5ba78ab7330b2fbf7b3cd389

commit 6d276665acabcc6b5ba78ab7330b2fbf7b3cd389
Author: yoshiki <yoshiki@chromium.org>
Date: Tue Dec 06 03:22:17 2016

Hide notification tray when the user flow doesn't allow

This patch hides the notification tray in the status bar when the user flow doesn't allow.

The patch is the follow-up of crrev.com/432116, because the previous patch was not enough.

BUG= 657934 
TEST=manual test (confirm no notification tray on supervised user creation flow)

Committed: https://crrev.com/88e6584140c183a90ad9aaab88daa8d41f146f6b
Review-Url: https://codereview.chromium.org/2530343005
Cr-Commit-Position: refs/heads/master@{#436509}

[modify] https://crrev.com/6d276665acabcc6b5ba78ab7330b2fbf7b3cd389/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/6d276665acabcc6b5ba78ab7330b2fbf7b3cd389/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc

Comment 7 by yoshiki@chromium.org, Dec 6 2016

Labels: -M-55 M-57 OS-Android
Status: Fixed (was: Started)
Should we merge this to M56? (I think it's too late for M55)

Comment 8 by yoshiki@chromium.org, Dec 6 2016

Labels: -OS-Android

Comment 9 by rookrishna@chromium.org, Dec 21 2016

Status: Verified (was: Fixed)
Verified on 57.0.2957/9107.0.0
►

Sign in to add a comment