New issue
Advanced search Search tips

Issue 657932 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

OmniboxTest#testSuggestionDirectionSwitching failing on JB devices

Reported by kra...@amazon.com, Oct 20 2016

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Run OmniboxTest#testSuggestionDirectionSwitching on a JellyBean device
(NOTE: Not Jelly Bean MR 1+. This only repros on SDK level 16)

What is the expected output?
The test passes

What do you see instead?
C   35.589s Main  ********************************************************************************
C   35.589s Main  [FAIL] org.chromium.chrome.browser.omnibox.OmniboxTest#testSuggestionDirectionSwitching:
C   35.589s Main  java.lang.RuntimeException: Exception occured while waiting for runnable
C   35.589s Main  	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:74)
C   35.589s Main  	at org.chromium.chrome.browser.omnibox.OmniboxTest.verifyOmniboxSuggestionAlignment(OmniboxTest.java:734)
C   35.589s Main  	at org.chromium.chrome.browser.omnibox.OmniboxTest.testSuggestionDirectionSwitching(OmniboxTest.java:711)
C   35.589s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   35.590s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   35.590s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   35.590s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
C   35.590s Main  	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
C   35.590s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C   35.590s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C   35.590s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
C   35.590s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
C   35.590s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:537)
C   35.590s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
C   35.590s Main  Caused by: java.util.concurrent.ExecutionException: junit.framework.AssertionFailedError: Incorrect layout direction of suggestion at index 0 expected:<1> but was:<0>
C   35.590s Main  	at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:223)
C   35.590s Main  	at java.util.concurrent.FutureTask.get(FutureTask.java:82)
C   35.590s Main  	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:72)
C   35.590s Main  	... 19 more
C   35.590s Main  Caused by: junit.framework.AssertionFailedError: Incorrect layout direction of suggestion at index 0 expected:<1> but was:<0>
C   35.590s Main  	at org.chromium.chrome.browser.omnibox.OmniboxTest$25.run(OmniboxTest.java:741)
C   35.590s Main  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
C   35.591s Main  	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
C   35.591s Main  	at java.util.concurrent.FutureTask.run(FutureTask.java:137)
C   35.591s Main  	at android.os.Handler.handleCallback(Handler.java:605)
C   35.591s Main  	at android.os.Handler.dispatchMessage(Handler.java:92)
C   35.591s Main  	at android.os.Looper.loop(Looper.java:137)
C   35.591s Main  	at android.app.ActivityThread.main(ActivityThread.java:4558)
C   35.591s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   35.591s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
C   35.591s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
C   35.591s Main  	at dalvik.system.NativeStart.main(Native Method)
C   35.591s Main  ********************************************************************************
C   35.591s Main  Summary
C   35.591s Main  ********************************************************************************
C   35.592s Main  [==========] 1 test ran.
C   35.592s Main  [  PASSED  ] 0 tests.
C   35.592s Main  [  FAILED  ] 1 test, listed below:
C   35.592s Main  [  FAILED  ] org.chromium.chrome.browser.omnibox.OmniboxTest#testSuggestionDirectionSwitching
C   35.592s Main
C   35.592s Main  1 FAILED TEST
C   35.592s Main  ********************************************************************************

Please use labels and text to provide additional information.
Checking layout directions on SDK level 16 is not supported according to
https://developer.android.com/reference/android/support/v4/view/ViewCompat.html#getLayoutDirection(android.view.View)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb65d4ce8c258089c80007408132ef89100eecd8

commit fb65d4ce8c258089c80007408132ef89100eecd8
Author: kraush <kraush@amazon.com>
Date: Thu Oct 20 20:50:24 2016

Do not test suggestion orientation on JB

JellyBean (SDK level 16) is hardcoded to always return
LAYOUT_DIRECTION_LTR when checking layout direction.
This change disables layout direction checking for those
devices.

BUG= 657932 

Review-Url: https://chromiumcodereview.appspot.com/2437153002
Cr-Commit-Position: refs/heads/master@{#426587}

[modify] https://crrev.com/fb65d4ce8c258089c80007408132ef89100eecd8/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment