New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657924 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 661307



Sign in to add a comment

Sync confirmation page doesn't work after the corp account signin.

Project Member Reported by zmin@chromium.org, Oct 20 2016

Issue description

Version: 56.0.2896.0
OS: Windows 8.1

A)
What steps will reproduce the problem?
(1) Open Chrome and sign in with a corp account
(2) Click "Link data" 
(3) Click "Undo" on Sync confirmation page

What is the expected output?
The profile is signed out.

What do you see instead?
The profile remains in sign in status. Even based on the log file, SyncConfirmationHandler::HandleUndo() has been called.


B)
What steps will reproduce the problem?
(1) Open Chrome and sign in with a corp account
(2) Click "Create a new profile" 

What is the expected output?
The sync confirmation page is displayed.

What do you see instead?
The sync confirmation page is displayed and dismissed automatically in a very short period.
Note that the dismiss will also trigger the HandleUndo() function. However, due to the issue A, the profile won't be signed out.




 

Comment 1 by zmin@chromium.org, Dec 6 2016

The issue B is now tracked by  crbug.com/663751 
Leave the ticket open as I can still repo the issue A with 57.0.2943.0

Comment 2 by zmin@chromium.org, Dec 6 2016

Cc: anthonyvd@chromium.org
Owner: msarda@chromium.org
Also, reassign it to msarda@ as the new identity team.
Status: Assigned (was: Untriaged)

Comment 4 by ew...@chromium.org, Dec 8 2016

Cc: ew...@chromium.org msarda@chromium.org yiinho@chromium.org zea@chromium.org zmin@chromium.org pnoland@chromium.org
 Issue 671388  has been merged into this issue.

Comment 5 by ew...@chromium.org, Dec 8 2016

Labels: -Pri-3 OS-Mac Pri-2
This is definitely higher than P3 (at least P2). When signing in with a corp account right now (I assume this applies to other dasher accounts as well), if the user clicks "Create new profile," sync won't start until they manually go to settings. It's not even surfaced as an error, so users may not even realize sync isn't working.

Mihai, we should have the same behavior here that I've described in Issue 661307 (for consumer accounts). When the user clicks "Create new profile," we should create a new profile, open a new window in that profile on the NTP, and immediately pop up the sync confirmation dialogue for the user to confirm sync settings before it starts.

Clicking "OK, GOT IT" should start syncing. Clicking "Settings" should go to sync settings so the user can configure settings before sync starts. Clicking "UNDO" should cancel the sign in (and, if possible, delete the newly created profile).

Let me know if you have any questions.

Comment 6 by ew...@chromium.org, Dec 8 2016

Labels: M-56

Comment 7 by ew...@chromium.org, Dec 8 2016

I guess technically my comment applies to  Issue 663751 . But really both scenarios (A and B) seem important to fix.

Comment 8 by msarda@chromium.org, Dec 16 2016

Blocking: 661307

Comment 9 by msarda@chromium.org, Dec 16 2016

Status: Started (was: Assigned)
S
I think this bug and  Issue 663751  have the same root cause.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/693b76e2b6c18a668f14df50316548214e316663

commit 693b76e2b6c18a668f14df50316548214e316663
Author: msarda <msarda@chromium.org>
Date: Thu Dec 22 22:35:53 2016

Remove the temporary flag to disable the sync confirmation page.

This CL removes the temporary hack to disable the sync confirmaton page
as the sync confirmation dialog is browser modal and thus it is no
longer dismissed on page navigation

BUG= 657924 

Review-Url: https://codereview.chromium.org/2600473002
Cr-Commit-Position: refs/heads/master@{#440528}

[modify] https://crrev.com/693b76e2b6c18a668f14df50316548214e316663/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/693b76e2b6c18a668f14df50316548214e316663/chrome/browser/ui/sync/one_click_signin_sync_starter.h

Status: Fixed (was: Started)
Status: Started (was: Fixed)
It seems there was a problem when lading CL https://codereview.chromium.org/2594703002/ that reverted the CL above. I'll prepare a new CL with the same fix.
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27

commit 0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27
Author: msarda <msarda@chromium.org>
Date: Wed Jan 04 15:48:13 2017

Remove the temporary flag to disable the sync confirmation page on linux an windows.

This CL removes the temporary hack to disable the sync confirmaton page
on linux and windows as the sync confirmation dialog is browser modal on
these platforms and thus the dialog is no longer dismissed on page
navigation.

BUG= 657924 

Review-Url: https://codereview.chromium.org/2614703002
Cr-Commit-Position: refs/heads/master@{#441380}

[modify] https://crrev.com/0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27/chrome/browser/ui/sync/one_click_signin_sync_starter.h

Can we mark this as Fixed now, Mihai?
Status: Fixed (was: Started)
It is fixed for Windows (not for macOS). However we're tracking mac in a different bug.
Cc: sayanta...@gmail.com gangwu@chromium.org
 Issue 678987  has been merged into this issue.

Sign in to add a comment