LayerTreeHostTestBreakSwapPromiseForVisibility is flaky |
|||||||
Issue descriptionThe log is here: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/5408/steps/cc_unittests/logs/stdio Failure: [----------] 1 test from LayerTreeHostTestBreakSwapPromiseForVisibility [ RUN ] LayerTreeHostTestBreakSwapPromiseForVisibility.RunMultiThread_DelegatingRenderer ../../cc/trees/layer_tree_host_unittest.cc:4625: Failure Value of: result_->did_not_swap_called Actual: true Expected: false [ FAILED ] LayerTreeHostTestBreakSwapPromiseForVisibility.RunMultiThread_DelegatingRenderer (10 ms) [----------] 1 test from LayerTreeHostTestBreakSwapPromiseForVisibility (12 ms total)
,
Nov 15 2017
,
Jan 26 2018
It doesn't look like we have a good owner for this test. Should we disable, or find a new one?
,
Jan 26 2018
,
Feb 5 2018
It sounds like we should disable this test.
,
Feb 6 2018
Yeah, disable flaky stuff till we fix them. :upside_down_face:
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a05281b258294ea29b81ca0279274b3d7772a04 commit 3a05281b258294ea29b81ca0279274b3d7772a04 Author: Antoine Labour <piman@chromium.org> Date: Wed Feb 07 23:57:19 2018 Disable flaky LayerTreeHostTestBreakSwapPromiseForVisibility Bug: 657910 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3abd524f1bc313ce6b92d14db4b1d051467d1fe9 Reviewed-on: https://chromium-review.googlesource.com/907744 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#535196} [modify] https://crrev.com/3a05281b258294ea29b81ca0279274b3d7772a04/cc/trees/layer_tree_host_unittest.cc
,
Feb 8 2018
Test disabled, reducing priority, unassigning.
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52988ee1eb317b7f1c4630d39535a3e23f4cd1c5 commit 52988ee1eb317b7f1c4630d39535a3e23f4cd1c5 Author: danakj <danakj@chromium.org> Date: Thu Apr 26 17:50:10 2018 cc: Deflake LayerTreeHostTestBreakSwapPromiseForVisibility test This test ends up posting a task more than once, the 2nd one of which races with the test exiting. When it runs first, it queues a second SwapPromise (with a pointer to the same result struct). Then on teardown the second SwapPromise checks the result struct to see that it did not already get a result and fails because the first SwapPromise already modified it. We add a bool to ensure the PostTask only happens on the first impl frame to avoid this. R=enne@chromium.org Bug: 657910 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2598562b4545de532a67f04dc71d097ae22d4399 Reviewed-on: https://chromium-review.googlesource.com/1028837 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#554073} [modify] https://crrev.com/52988ee1eb317b7f1c4630d39535a3e23f4cd1c5/cc/trees/layer_tree_host_unittest.cc
,
Apr 26 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by danakj@chromium.org
, Nov 15 2017Components: Internals>Compositing Tests>Flaky
Labels: -OS-Android -Pri-3 Pri-1
Summary: LayerTreeHostTestBreakSwapPromiseForVisibility is flaky (was: LayerTreeHostTestBreakSwapPromiseForVisibility.RunMultiThread_DelegatingRenderer failed)