New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657900 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 663536
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----
Team-Accessibility

Blocked on:
issue 663536

Blocking:
issue 462133


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews(a11y): Menus in origin info bubble aren't usable with VO

Project Member Reported by sdy@chromium.org, Oct 20 2016

Issue description

Version: 56.0.2896.0
OS: 10.12

What steps will reproduce the problem?
(1) With VoiceOver on, open the origin info bubble.
(2) Navigate to one of the permissions pop-up menus.
(3) Try to use it.

What is the expected output?
- The menu is announced as "<current value (e.g. Ask by default>, pop up button".
- VO+space opens the menu.

What do you see instead?
- The menu is announced as "<name (e.g. Location)>, combo box" (it isn't a combo box).
- VO+space does nothing.
- VO+shift+down announces "in combo box". No other interaction seems to be possible.
 
Status: Available (was: Untriaged)

Comment 2 by tapted@chromium.org, Dec 12 2016

Blocking: 462133
Owner: patricia...@chromium.org
Status: Assigned (was: Available)
patricialor@, can you have a look at this please? :)
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Labels: -Type-Bug
This should be straightforward - we just need "VO+space" to work. Currently down-arrow and space by themselves work, but VO+Space should do the same as space.

Note VO+Space also appears to be broken inside WebContents currently for comboboxes. It does "something", but it doesn't result in showing the menu on <select> elements. Seems to clear the box (it's weird).

I think it's fine that the items present themselves as Combo boxes. It's just a quirk of the implementation of the Cocoa OIB that they're popup buttons.

Comment 6 by sdy@chromium.org, Apr 6 2017

On Mac, isn't a combo box the control that allows text input and selection from a list? E.g. in the advanced section of System Preferences -> Language and Region, there are combo boxes that let you enter anything you want as a decimal separator, but have the most common choices in the menu.
Screen Shot 2017-04-06 at 2.38.02 AM.png
268 KB View Download
Huh. I think you're right. In which case 

void Combobox::GetAccessibleNodeData(ui::AXNodeData* node_data) {
  node_data->role = ui::AX_ROLE_COMBO_BOX;

just needs to be

  node_data->role = ui::AX_ROLE_POP_UP_BUTTON,

on Mac since there's definitely no textfield there. Nice find!
Labels: -M-56 MacViews-Dialogs

Comment 9 by tapted@chromium.org, Apr 13 2017

Blockedon: 663536
Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility
Cc: patricia...@chromium.org
Owner: tapted@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2946783003
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16b69bc237e5f5d2cc75681aec6d2c130a05f14

commit d16b69bc237e5f5d2cc75681aec6d2c130a05f14
Author: tapted <tapted@chromium.org>
Date: Wed Jun 21 10:06:42 2017

Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG= 657900 ,  663536 

Review-Url: https://codereview.chromium.org/2946783003
Cr-Commit-Position: refs/heads/master@{#481163}

[modify] https://crrev.com/d16b69bc237e5f5d2cc75681aec6d2c130a05f14/ui/views/controls/combobox/combobox.cc

Cc: kavvaru@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac 10.12.5 using chrome version 61.0.3141.0 with the below steps

1.Open Permission.site,Clicked on page info
2.Enable Voice over
3.select any Ask option
4.The menu is announced as "<current value (e.g. Ask by default>, pop up button"
5. VO+space opened the menu

Please find the attached screen cast for the same.But observed the same behaviour on reported version as well 56.0.2896.0.
tapted @ could you Please confirm if anything missed here.

Thanks,
Mergedinto: 663536
Status: Duplicate (was: Started)

Sign in to add a comment