New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657874 link

Starred by 1 user
Status: Started
Owner:
█ s...@chromium.org
Last visit > 30 days ago
Cc:
minyue@chromium.org
█ wzhong@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Opus does not compile for non-neon ARM builds.

Project Member Reported by s...@chromium.org, Oct 20 2016 
Building Opus with the following args will break the build:

target_cpu = "arm"
arm_use_neon = false

This is because arm_neon.h may not be included when -mfpu=enon is not passed at compile-time. This is impacting Chromecast Audio builds which don't use NEON.

The right solution here seems to be to guard neon sources and defines with this GN arg.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d06b0c916aa422a57e58d634cb73c2909b320d

commit 22d06b0c916aa422a57e58d634cb73c2909b320d
Author: slan <slan@chromium.org>
Date: Tue Nov 29 17:51:47 2016

[Opus] Only include NEON sources and macros when arm_use_neon==true.

arm_neon.h throws an error when included in a non-neon build. Only
include neon-related sources when use_arm_neon is true.

BUG=657874

Review-Url: https://codereview.chromium.org/2427333004
Cr-Commit-Position: refs/heads/master@{#435027}

[modify] https://crrev.com/22d06b0c916aa422a57e58d634cb73c2909b320d/third_party/opus/BUILD.gn

Comment 2 by benhenry@google.com, Jan 11 

You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.
►

Sign in to add a comment