New issue
Advanced search Search tips

Issue 657869 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

"Skip" test expectations should be un-skipped by specific expectations in overriding expectation files.

Project Member Reported by qyears...@chromium.org, Oct 20 2016

Issue description

For example, currently the whole directory imported/wpt/service-workers is marked as [ Skip ] in TestExpectations:

   crbug.com/602693  imported/wpt/service-workers [ Skip ]

And there are particular [ Pass ] expectations for particular tests:

   crbug.com/602693  imported/wpt/service-workers/service-worker/client-navigate.https.html [ Pass ]
   crbug.com/602693  imported/wpt/service-workers/service-worker/clients-get-cross-origin.https.html [ Pass ]
   crbug.com/602693  imported/wpt/service-workers/service-worker/clients-matchall-client-types.https.html [ Pass ]
   crbug.com/602693  imported/wpt/service-workers/service-worker/controller-on-disconnect.https.html [ Pass ]

The behavior that we might expect is that these particular tests should be un-skipped (no longer skipped), but they're all still skipped.
 
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Summary: "Skip" test expectations should be un-skipped by specific expectations in overriding expectation files. (was: "Skip" test expectations are not un-skipped by specific expectations in overriding expectation files.)
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by danyao@chromium.org, Apr 13 2018

Cc: foolip@chromium.org
Status: Available (was: Untriaged)
It seems reasonable to leave this in "Available". foolip@ - WDYT?
Status: Fixed (was: Available)
The imported/wpt/service-workers directory (now external/wpt/service-workers) is no longer skipped, so calling this fixed.

Sign in to add a comment