New issue
Advanced search Search tips

Issue 657856 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue webrtc:7066
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 657854
issue webrtc:6758
issue 669877

Blocking:
issue 627816



Sign in to add a comment

RTCPeerConnection.getStats: RTCOutboundRTPStreamStats

Project Member Reported by hbos@chromium.org, Oct 20 2016

Issue description

Add RTCOutboundRTPStreamStats and all of its members.
https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*

dictionary RTCOutboundRTPStreamStats : RTCRTPStreamStats {
    unsigned long      packetsSent;
    unsigned long long bytesSent;
    double             targetBitrate;
    double             roundTripTime;
    unsigned long      framesEncoded;  // Since 14 December 2016 Draft
};
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29

commit 69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29
Author: hbos <hbos@webrtc.org>
Date: Mon Oct 31 21:48:26 2016

RTCOutboundRTPStreamStats[1] added.

This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.

RTCStatsReport also gets a timestamp and ToString.

[1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
[2] https://w3c.github.io/webrtc-stats/#streamstats-dict*

BUG= chromium:627816 ,  chromium:657856 ,  chromium:657854 

Review-Url: https://codereview.webrtc.org/2456463002
Cr-Commit-Position: refs/heads/master@{#14860}

[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector.h
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstats.h
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/api/stats/rtcstatsreport.h
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstats.cc
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstats_objects.cc
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstatsreport.cc
[modify] https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29/webrtc/stats/rtcstatsreport_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec

commit 7eaa83622b19c7afa80139d3261e6bfbe2cae6ec
Author: perkj <perkj@webrtc.org>
Date: Tue Nov 01 06:52:25 2016

Revert of RTCOutboundRTPStreamStats added. (patchset #3 id:80001 of https://codereview.webrtc.org/2456463002/ )

Reason for revert:
Breaks Chrome FYI.
peerconnection_unittest calls RTCStatsReport::Create without  parameters.

Original issue's description:
> RTCOutboundRTPStreamStats[1] added.
>
> This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
> are supported in this CL, this must be addressed before closing the
> issue.
>
> RTCStatsReport also gets a timestamp and ToString.
>
> [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
> [2] https://w3c.github.io/webrtc-stats/#streamstats-dict*
>
> BUG= chromium:627816 ,  chromium:657856 ,  chromium:657854 
>
> Committed: https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29
> Cr-Commit-Position: refs/heads/master@{#14860}

TBR=hta@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:627816 ,  chromium:657856 ,  chromium:657854 

Review-Url: https://codereview.webrtc.org/2465223002
Cr-Commit-Position: refs/heads/master@{#14863}

[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/rtcstatscollector.h
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/stats/rtcstats.h
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/api/stats/rtcstatsreport.h
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/stats/rtcstats.cc
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/stats/rtcstats_objects.cc
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/stats/rtcstatsreport.cc
[modify] https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec/webrtc/stats/rtcstatsreport_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6ded19086432b395a85c9a0206fa8a3bc6d33caf

commit 6ded19086432b395a85c9a0206fa8a3bc6d33caf
Author: hbos <hbos@webrtc.org>
Date: Tue Nov 01 08:50:46 2016

RTCOutboundRTPStreamStats[1] added.

This also adds RTCRTPStreamStats[2] which it derives from. Not all stats
are supported in this CL, this must be addressed before closing the
issue.

RTCStatsReport also gets a timestamp and ToString.

[1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
[2] https://w3c.github.io/webrtc-stats/#streamstats-dict*

  This was previously reverted https://codereview.webrtc.org/2465223002/
  because RTCStatsReport::Create added a new parameter not used by
  Chromium unittests. Temporarily added a default value to the argument
  to be removed after rolling and updating Chromium.

BUG= chromium:627816 ,  chromium:657856 ,  chromium:657854 
TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2470703002
Cr-Commit-Position: refs/heads/master@{#14866}

[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector.h
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstats.h
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/api/stats/rtcstatsreport.h
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstats.cc
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstats_objects.cc
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstatsreport.cc
[modify] https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf/webrtc/stats/rtcstatsreport_unittest.cc

Comment 4 by hbos@webrtc.org, Nov 23 2016

Blockedon: webrtc:6758

Comment 5 by hbos@chromium.org, Nov 30 2016

Blockedon: 669877

Comment 6 by hbos@chromium.org, Dec 21 2016

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6769c4941817ac3d5b967d0aafa1304c06d0672e

commit 6769c4941817ac3d5b967d0aafa1304c06d0672e
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:35:13 2017

RTC[In/Out]boundRTPStreamStats: qpSum,framesDecoded,framesEncoded added.

Recently added to the spec:
RTCRTPStreamStats.qpSum - https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
RTCInboundRTPStreamStats.framesDecoded - https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
RTCOutboundRTPStreamStats.framesEncoded - https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded

These are added and collected. However, the qpSum is only collected in
the outbound case. It should be collected in the inbound case before
closing  crbug.com/657855 

BUG= chromium:657854 ,  chromium:657855 ,  chromium:657856 

Review-Url: https://codereview.webrtc.org/2588373005
Cr-Commit-Position: refs/heads/master@{#15872}

[modify] https://crrev.com/6769c4941817ac3d5b967d0aafa1304c06d0672e/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/6769c4941817ac3d5b967d0aafa1304c06d0672e/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/6769c4941817ac3d5b967d0aafa1304c06d0672e/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/6769c4941817ac3d5b967d0aafa1304c06d0672e/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/6769c4941817ac3d5b967d0aafa1304c06d0672e/webrtc/stats/rtcstats_objects.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a

commit a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
Author: hbos <hbos@chromium.org>
Date: Mon Jan 02 16:43:12 2017

RTCPeerConnection.getStats: Whitelist updated after spec changed.

This is the whitelist used in the Chromium integration test.

New members:
- RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
- RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
- RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded
- RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid
- RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote
- RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted

Renamed members, removed old names (https://codereview.webrtc.org/2576383002/):
- RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
- RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime

NOTRY=True
BUG= chromium:627816 ,  chromium:657854 ,  chromium:657855 ,  chromium:657856 ,  chromium:632723 

Review-Url: https://codereview.chromium.org/2590293004
Cr-Commit-Position: refs/heads/master@{#441073}

[modify] https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a/chrome/test/data/webrtc/peerconnection_getstats.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/84abeb1d37ee27147674cd94a5606bd4ac725d9a

commit 84abeb1d37ee27147674cd94a5606bd4ac725d9a
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 14:16:44 2017

RTC[In/Out]boundRTPStreamStats.mediaTrackId collected.

Based on the mapping between [Audio/Video]TrackInterface and
[Voice/Video][Sender/Receiver]Info.

The IDs of RTCMediaStreamTrackStats are updated to distinguish between
local and remote cases. Previously, if local and remote cases had the
same label only one of them would be included in the report (bug).

BUG= webrtc:6758 ,  chromium:657854 ,  chromium:657855 ,  chromium:657856 ,  chromium:627816 

Review-Url: https://codereview.webrtc.org/2610843003
Cr-Commit-Position: refs/heads/master@{#16095}

[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector.h
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/statscollector_unittest.cc
[modify] https://crrev.com/84abeb1d37ee27147674cd94a5606bd4ac725d9a/webrtc/api/test/mock_peerconnection.h

Comment 10 by hbos@chromium.org, Jan 26 2017

Mergedinto: webrtc:7066
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.

Sign in to add a comment