New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 462133



Sign in to add a comment

MacViews(a11y): Controls on an inactive tab in the cookies dialog are seen by VoiceOver

Project Member Reported by sdy@chromium.org, Oct 20 2016

Issue description

Version: 56.0.2895.0
OS: 10.11, 10.12

What steps will reproduce the problem?
(1) Bring up the cookies dialog from the OIB.
(2) Explore with VoiceOver.

What is the expected output?
Only visible controls are announced.

What do you see instead?
Allow and Clear on Exit buttons are announced when on the Allowed tab, but they're only visible on the Blocked tab.
 

Comment 1 by sdy@chromium.org, Oct 24 2016

Summary: MacViews(a11y): Controls on an inactive tab in the cookies dialog are seen by VoiceOver (was: Controls on an inactive tab in the cookies dialog are seen by VoiceOver)
Status: Available (was: Untriaged)

Comment 3 by tapted@chromium.org, Dec 12 2016

Blocking: 462133
Owner: patricia...@chromium.org
Status: Started (was: Available)
In progress here: https://codereview.chromium.org/2601883002/
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452d2878e6c634245c5757fc0549876e4631722c

commit 452d2878e6c634245c5757fc0549876e4631722c
Author: patricialor <patricialor@chromium.org>
Date: Thu Dec 29 22:48:35 2016

MacViews/a11y: Mark Views as invisible if their parents are invisible.

Currently, only Views returning false from View::visible() will be marked
invisible to a11y clients. This doesn't account for all invisible Views, since
Views which have an invisible ancestor will also be invisible, but still return
true from View::visible(). Account for this when tagging Views invisible for
a11y by switching to View::IsDrawn() instead.

MacViews a11y already ignores invisible Views, so this will fix issues where
a11y clients are seeing invisible controls.

BUG= 657848 ,  660230 
TEST=On Mac, with the #secondary-ui-md flag turned on, open the OIB by clicking
the icon on the left of the URL, then open the collected cookies dialog by
clicking the link under "Cookies", which should read "<X> in use". Turn on
VoiceOver by pressing Cmd+F5 and navigate through the contents of the "Allowed"
tab with VO by pressing Ctrl+Right Arrow. Verify it doesn't read out controls
that belong to the "Blocked" tab.

Review-Url: https://codereview.chromium.org/2601883002
Cr-Commit-Position: refs/heads/master@{#441001}

[modify] https://crrev.com/452d2878e6c634245c5757fc0549876e4631722c/ui/views/accessibility/native_view_accessibility.cc
[modify] https://crrev.com/452d2878e6c634245c5757fc0549876e4631722c/ui/views/accessibility/native_view_accessibility_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment