New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657837 link

Starred by 1 user
Status: Fixed
Owner:
█ rob.b...@samsung.com
Email to this user bounced
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Make table.deleteRow(-1) a no-op when there are no rows

Reported by rob.b...@samsung.com, Oct 20 2016 
The html5 spec changed deleteRow(-1) behavior:
https://github.com/whatwg/html/pull/1924

Right now we throw an exception but we want deleteRow(-1) to be a no-op.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b

commit e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b
Author: rob.buis <rob.buis@samsung.com>
Date: Mon Oct 24 15:09:03 2016

Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG= 657837 

Review-Url: https://codereview.chromium.org/2427963004
Cr-Commit-Position: refs/heads/master@{#427073}

[delete] https://crrev.com/78c98bcbd05238c7ba83aeb17cebbe3f77e14636/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/the-table-element/remove-row-expected.txt
[modify] https://crrev.com/e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Comment 2 by rob.b...@samsung.com, Oct 24 2016

Status: Fixed (was: Assigned)
Fixed with r427073.
►

Sign in to add a comment