PlzNavigate: <object> must failback to its alternative content. |
||
Issue description
With --enable-browser-side-navigation, <object> tag doesn't works properly.
If the navigation to the "data" attribute fails, it must display the alternative content instead of an error frame.
A minimal example is:
<body>
<object data="not_found">
alternative content
</object>
</body>
Tests that fail because of this bug:
- fast/css/acid2-pixel.html
- fast/css/acid2.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/table/giantCellspacing.html
- http/tests/misc/resource-timing-sizes-tags.html
- imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- plugins/object-onfocus-mutation-crash.html
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23f81850ae332ea6d7a564072aac6937f820822b commit 23f81850ae332ea6d7a564072aac6937f820822b Author: arthursonzogni <arthursonzogni@chromium.org> Date: Thu Oct 20 15:53:51 2016 PlzNavigate: Classify untriaged failling tests. BUG= 657834 Review-Url: https://chromiumcodereview.appspot.com/2430953005 Cr-Commit-Position: refs/heads/master@{#426487} [modify] https://crrev.com/23f81850ae332ea6d7a564072aac6937f820822b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
,
Oct 27 2016
Issue 648600 has been merged into this issue.
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb2aaf9abe13bdd12fbba17fba9901d430057ca0 commit bb2aaf9abe13bdd12fbba17fba9901d430057ca0 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Nov 07 14:13:06 2016 PlzNavigate: Allow frames to fallback to alternative content. This CL gives frames the opportunity to show alternative content when <object data="..."> navigation fails instead of displaying an error page. It fixes a collection of tests(see bug description) that fail with the --enable-browser-side-navigation flag. BUG= 657834 Review-Url: https://codereview.chromium.org/2439903003 Cr-Commit-Position: refs/heads/master@{#430266} [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/content/renderer/render_frame_impl.cc [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/core/frame/FrameOwner.h [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/core/html/HTMLObjectElement.h [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/web/RemoteFrameOwner.h [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/bb2aaf9abe13bdd12fbba17fba9901d430057ca0/third_party/WebKit/public/web/WebLocalFrame.h
,
Nov 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by arthurso...@chromium.org
, Oct 20 2016