New issue
Advanced search Search tips

Issue 657831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Shipping Ignition requires rebaseline of Blink layout test expectations

Project Member Reported by mstarzinger@chromium.org, Oct 20 2016

Issue description

Shipping Ignition (V8's interpreter) on a subset of language features requires a rebaseline of the following Blink layout tests:

* http/tests/inspector-enabled/console-stack-overflow-source-url.html: The RangeError thrown due to a stack overflow happens at a different source position. The stack overflow happens during the call dispatch instead of in the function prologue. Only the position of the topmost stack trace entry changes. This is WAI.

* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: The live range of temporary operands can be different with Ignition. In this case the lifetime of the {xhr.response} temporary extends beyond the explicit GC call until the temporary slot is reused. This is WAI.

This is a tracking bug to rebaseline the above two test expectations.
 
Cc: jochen@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812d47a3a152f6c74040ca9a7121a48ad61a1507

commit 812d47a3a152f6c74040ca9a7121a48ad61a1507
Author: mstarzinger <mstarzinger@chromium.org>
Date: Fri Oct 21 12:30:48 2016

[v8] Mark layout test for rebase after enabling Ignition.

Enabling Ignition on a subset of language features requires a rebaseline
of two Blink layout tests after V8 has rolled and Ignition is enabled.

R=jochen@chromium.org
BUG= chromium:657831 ,chromium:588103

Review-Url: https://chromiumcodereview.appspot.com/2442433002
Cr-Commit-Position: refs/heads/master@{#426775}

[modify] https://crrev.com/812d47a3a152f6c74040ca9a7121a48ad61a1507/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee5e54faa37c4a02b21e1d0cfb5defb184f4d75

commit dee5e54faa37c4a02b21e1d0cfb5defb184f4d75
Author: mstarzinger <mstarzinger@chromium.org>
Date: Thu Nov 17 09:29:31 2016

[v8] Mark layout test for rebase after enabling Ignition.

Enabling Ignition on a subset of language features requires a rebaseline
of two Blink layout tests. The corresponding V8 roll has made it into
Chromium two weeks ago and is sticking since then.

R=rmcilroy@chromium.org
BUG= chromium:657831 

Review-Url: https://codereview.chromium.org/2504943003
Cr-Commit-Position: refs/heads/master@{#432828}

[modify] https://crrev.com/dee5e54faa37c4a02b21e1d0cfb5defb184f4d75/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment