Add Time to First Contentful Paint Progressive Web Metric. Doc here: https://docs.google.com/document/d/1kKGZO3qlBBVOSZTf-T8BOMETzk3bY15SC-jsMJWv4IE/edit
Shubhie, you're driving this currently, right?
Yep.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a2eb472fde51de48c095c9c208101c534ac211e commit 9a2eb472fde51de48c095c9c208101c534ac211e Author: panicker <panicker@chromium.org> Date: Wed Apr 19 19:23:17 2017 Plumb activation time in cc to Blink Scheduler in Main BUG= 657826 , 657825 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2778223005 Cr-Commit-Position: refs/heads/master@{#465701} [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/output/begin_frame_args.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/output/begin_frame_args.h [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/output/begin_frame_args_unittest.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/scheduler/begin_frame_source.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/scheduler/scheduler.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/scheduler/scheduler.h [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/scheduler/scheduler_unittest.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/test/begin_frame_args_test.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/trees/layer_tree_host_unittest_proxy.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/trees/proxy_impl.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/trees/proxy_main.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/cc/trees/single_thread_proxy.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/content/browser/compositor/gpu_vsync_begin_frame_source.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc [modify] https://crrev.com/9a2eb472fde51de48c095c9c208101c534ac211e/ui/android/window_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aeea939c0f289b85181b6e8fc9c0966451e9369 commit 8aeea939c0f289b85181b6e8fc9c0966451e9369 Author: rogerm <rogerm@chromium.org> Date: Wed Apr 19 21:26:57 2017 Revert of Plumb activation time to main (patchset #16 id:280001 of https://codereview.chromium.org/2778223005/ ) Reason for revert: Failure observed in LayerTreeHostProxyTestActivationTime.RunMultiThread_DelegatingRenderer https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59244%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests%2F0%2Flogs%2FLayerTreeHostProxyTestActivationTime.RunMultiThread_DelegatingRenderer%2F0 Original issue's description: > Plumb activation time in cc to Blink Scheduler in Main > > BUG= 657826 , 657825 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2778223005 > Cr-Commit-Position: refs/heads/master@{#465701} > Committed: https://chromium.googlesource.com/chromium/src/+/9a2eb472fde51de48c095c9c208101c534ac211e TBR=brianderson@chromium.org,ccameron@chromium.org,alexclarke@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,panicker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 657826 , 657825 Review-Url: https://codereview.chromium.org/2833603002 Cr-Commit-Position: refs/heads/master@{#465757} [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/output/begin_frame_args.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/output/begin_frame_args.h [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/output/begin_frame_args_unittest.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/scheduler/begin_frame_source.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/scheduler/scheduler.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/scheduler/scheduler.h [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/scheduler/scheduler_unittest.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/test/begin_frame_args_test.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/trees/layer_tree_host_unittest_proxy.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/trees/proxy_impl.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/trees/proxy_main.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/cc/trees/single_thread_proxy.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/content/browser/compositor/gpu_vsync_begin_frame_source.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc [modify] https://crrev.com/8aeea939c0f289b85181b6e8fc9c0966451e9369/ui/android/window_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da commit 34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da Author: panicker <panicker@chromium.org> Date: Fri May 05 04:09:46 2017 Use swap-promise to track first* paint up until swap time. BUG= 657826 , 657825 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2835763002 Cr-Commit-Position: refs/heads/master@{#469594} [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/content/renderer/gpu/render_widget_compositor.h [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/third_party/WebKit/Source/core/paint/PaintTiming.cpp [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/third_party/WebKit/Source/core/paint/PaintTiming.h [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/third_party/WebKit/public/platform/DEPS [modify] https://crrev.com/34797fd73ea2d3b09f27c84d50eee3c0dfdbc4da/third_party/WebKit/public/platform/WebLayerTreeView.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e0ee81a6380db6c714980a30a53a8c002ff46e7 commit 2e0ee81a6380db6c714980a30a53a8c002ff46e7 Author: panicker <panicker@chromium.org> Date: Tue May 09 23:55:02 2017 Add tests for paint-timing, and move existing tests to same location BUG= 657826 , 657825 Review-Url: https://codereview.chromium.org/2860143002 Cr-Commit-Position: refs/heads/master@{#470441} [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html [rename] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-only.html [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/no-paint.html [rename] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/resources/circle.svg [add] https://crrev.com/2e0ee81a6380db6c714980a30a53a8c002ff46e7/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/resources/circles.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6706c46e3ee46e567028602861da551164c1772 commit f6706c46e3ee46e567028602861da551164c1772 Author: panicker <panicker@chromium.org> Date: Tue May 16 04:29:04 2017 Switch paint-timing runtime flag to experimental Link to Intent to Implement thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/kyll3WFKTig/fI8WPhkxBgAJ;context-place=forum/blink-dev BUG= 657826 , 657825 Review-Url: https://codereview.chromium.org/2858633003 Cr-Commit-Position: refs/heads/master@{#472016} [modify] https://crrev.com/f6706c46e3ee46e567028602861da551164c1772/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/472fbf0ccd5b03bf09f4616d437ad65a8ca62f2b commit 472fbf0ccd5b03bf09f4616d437ad65a8ca62f2b Author: panicker <panicker@chromium.org> Date: Tue May 23 23:05:43 2017 Buffer paint entries so they can be queried with getEntries BUG= 657826 , 657825 Review-Url: https://codereview.chromium.org/2899023003 Cr-Commit-Position: refs/heads/master@{#474096} [modify] https://crrev.com/472fbf0ccd5b03bf09f4616d437ad65a8ca62f2b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [modify] https://crrev.com/472fbf0ccd5b03bf09f4616d437ad65a8ca62f2b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp [modify] https://crrev.com/472fbf0ccd5b03bf09f4616d437ad65a8ca62f2b/third_party/WebKit/Source/core/timing/PerformanceBase.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7366cc17bd54dc1f347e98e40668cf845e472b5 commit e7366cc17bd54dc1f347e98e40668cf845e472b5 Author: panicker <panicker@chromium.org> Date: Thu May 25 01:03:37 2017 Update PaintTiming Web Perf APIs for FP & FCP to report swap time BUG= 657826 , 657825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2873033002 Cr-Commit-Position: refs/heads/master@{#474504} [modify] https://crrev.com/e7366cc17bd54dc1f347e98e40668cf845e472b5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e7366cc17bd54dc1f347e98e40668cf845e472b5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [modify] https://crrev.com/e7366cc17bd54dc1f347e98e40668cf845e472b5/third_party/WebKit/Source/core/paint/PaintTiming.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc1fe7bf2508b1301933004e0f4e44bf55b3032a commit fc1fe7bf2508b1301933004e0f4e44bf55b3032a Author: yosin <yosin@chromium.org> Date: Thu May 25 06:52:37 2017 Revert of Update PaintTiming Web Perf APIs for FP & FCP to report swap time (patchset #3 id:40001 of https://codereview.chromium.org/2873033002/ ) Reason for revert: Probably causes leaks: * http/tests/performance-timing/paint-timing/observable.html * virtual/mojo-loading/http/tests/performance-timing/paint-timing/observable.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4956 Original issue's description: > Update PaintTiming Web Perf APIs for FP & FCP to report swap time > > BUG= 657826 , 657825 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2873033002 > Cr-Commit-Position: refs/heads/master@{#474504} > Committed: https://chromium.googlesource.com/chromium/src/+/e7366cc17bd54dc1f347e98e40668cf845e472b5 TBR=tdresser@chromium.org,wangxianzhu@chromium.org,panicker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 657826 , 657825 Review-Url: https://codereview.chromium.org/2904023002 Cr-Commit-Position: refs/heads/master@{#474590} [modify] https://crrev.com/fc1fe7bf2508b1301933004e0f4e44bf55b3032a/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/fc1fe7bf2508b1301933004e0f4e44bf55b3032a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [modify] https://crrev.com/fc1fe7bf2508b1301933004e0f4e44bf55b3032a/third_party/WebKit/Source/core/paint/PaintTiming.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/600950a6cab835f6a2932ead72cb0c0a34782fa5 commit 600950a6cab835f6a2932ead72cb0c0a34782fa5 Author: panicker <panicker@chromium.org> Date: Wed Jun 14 06:23:14 2017 Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time Update tests to use capturePixelsAsyncThen to generate a frame, and check buffered values. BUG= 657825 , 657826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2932593002 Cr-Commit-Position: refs/heads/master@{#479303} [add] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/basetest.html [add] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-bg-image.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html [add] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-bg-color.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-only.html [delete] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/no-paint.html [delete] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [modify] https://crrev.com/600950a6cab835f6a2932ead72cb0c0a34782fa5/third_party/WebKit/Source/core/paint/PaintTiming.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/683525a926a264914943c0100692052aa5ff7e32 commit 683525a926a264914943c0100692052aa5ff7e32 Author: Shubhie Panicker <panicker@chromium.org> Date: Thu Jun 22 23:55:03 2017 Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time Update tests to use capturePixelsAsyncThen to generate a frame, and check buffered values. BUG= 657825 , 657826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2932593002 Cr-Original-Commit-Position: refs/heads/master@{#479303} Review-Url: https://codereview.chromium.org/2953993002 . Cr-Commit-Position: refs/branch-heads/3112@{#446} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [add] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/basetest.html [add] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-bg-image.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html [add] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-bg-color.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-only.html [delete] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/no-paint.html [delete] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html [modify] https://crrev.com/683525a926a264914943c0100692052aa5ff7e32/third_party/WebKit/Source/core/paint/PaintTiming.cpp
Comment 1 by panicker@chromium.org
, Nov 11 2016