New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657816 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove temporary keyboard accelerator using DEV_TOGGLE_UNIFIED_DESKTOP

Project Member Reported by kylec...@chromium.org, Oct 20 2016

Issue description

I'm stealing the DEV_TOGGLE_UNIFIED_DESKTOP keyboard accelerator temporarily in the mustash build. The keyboard accelerator is otherwise unused (as unified desktop isn't supported yet) and triggers changing the display resolution since there is no other way to do so.

Once the settings page works we'll be able to change the display resolution and this keyboard accelerator will be unnecessary. So this usage should be removed before launch.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4edef864ea405f5ede2f2fde973a63855bc784f

commit c4edef864ea405f5ede2f2fde973a63855bc784f
Author: kylechar <kylechar@chromium.org>
Date: Wed Jul 12 01:08:44 2017

Remove mustash accelerator special cases.

Display management is part of the ash process again in mustash. Remove
the special cases for most display management accelerators since they no
longer work.

Bug:  612331 , 657816 
Change-Id: I43d4f495347a1b8e880f3e5c5125c9144e68ed15
Reviewed-on: https://chromium-review.googlesource.com/567137
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485756}
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands.h
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands_aura.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_commands_aura.h
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/c4edef864ea405f5ede2f2fde973a63855bc784f/ash/mus/accelerators/accelerator_controller_delegate_mus.cc

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment