OS_MACOSX is defined on both iOS and macOS. |
|||||
Issue descriptionDescribe infrastructure request/issue: The fact that OS_MAC is defined on both platforms is confusing and potentially dangerous. I understand that it's automatically set from system headers and compiler defines. We recently had a discussion about this in WebRTC, but decided against making this change in the interest of not diverging from Chromium. Now I'm raising the issue here in order to continue the discussion. See https://bugs.chromium.org/p/webrtc/issues/detail?id=6453 for the discussion on the WebRTC tracker.
,
Oct 24 2016
rohitrao,sdefresne for input. There are good reasons to use OS_MAC for iOS as well.
,
Oct 24 2016
Main reason is to align with Apple that define both TARGET_OS_MAC and TARGET_OS_IPHONE when building for iOS.
,
Oct 24 2016
With #3, I wanted to say that the main reason it is so currently "is to align with Apple that define both TARGET_OS_MAC and TARGET_OS_IPHONE when building for iOS." (i.e. I'm summarising my email on gn-dev: https://groups.google.com/a/chromium.org/d/msg/gn-dev/A4pPWrUD0m8/18DH0ojDAQAJ). I'm not trying to imply that this should always holds true, just explaining how we ended up here.
,
Oct 27 2016
Marking Available, please switch back to Untriaged if you think this is important.
,
Feb 28 2017
Closing this as it seems there are valid reasons behind it and changing it would be a lot of work. Please reopen if you feel strongly about this. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kthelgason@chromium.org
, Oct 20 2016