New issue
Advanced search Search tips

Issue 657793 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in ChromeSecurityStateModelClient::GetSecurityStyle

Project Member Reported by ClusterFuzz, Oct 20 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5693838410907648

Fuzzer: inferno_webbot
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  ChromeSecurityStateModelClient::GetSecurityStyle
  Browser::GetSecurityStyle
  content::WebContentsImpl::DidChangeVisibleSSLState
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=426296:426375

Minimized Testcase (0.06 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv942cyZNvMGXq4JZWdHKVkRxSsIkHA2HR8CCDnvZJurd6zWYPyfVHcDDW25zVGPiAkzWvZkTdVZ04Q-8goAbUWevPxoGQT7f2S4IYo6nUb7yeJB-tpGIK4bMvEwahf4ZGtAuMHF9vINNujvwknb6_1M74Ni0cg?testcase_id=5693838410907648
<script>
window.location = "http://xn--pckuas0o.com";</script>


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 20 2016

Labels: M-55
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 20 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 20 2016

Labels: Pri-1

Comment 4 by gov...@chromium.org, Oct 21 2016

Cc: awhalley@chromium.org
awhalley@chromium.org,  please make sure that fix is ready and merged to M55 branch 2883 before 4:00 PM PT on Monday (10/24) as this is reported as M55 Beta blocker. Thank you.

Comment 5 by est...@chromium.org, Oct 21 2016

This was caught by msan bots and fixed in https://codereview.chromium.org/2433373004/. I'm rerunning Clusterfuzz to be sure.

However, I'm not sure why Clusterfuzz marked this as M55, because the bug was introduced in https://chromium.googlesource.com/chromium/src/+/22b1cd4 which was well after branch point.
Project Member

Comment 6 by ClusterFuzz, Oct 21 2016

ClusterFuzz has detected this issue as fixed in range 426561:426648.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5693838410907648

Fuzzer: inferno_webbot
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  ChromeSecurityStateModelClient::GetSecurityStyle
  Browser::GetSecurityStyle
  content::WebContentsImpl::DidChangeVisibleSSLState
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=426296:426375
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=426561:426648

Minimized Testcase (0.06 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv942cyZNvMGXq4JZWdHKVkRxSsIkHA2HR8CCDnvZJurd6zWYPyfVHcDDW25zVGPiAkzWvZkTdVZ04Q-8goAbUWevPxoGQT7f2S4IYo6nUb7yeJB-tpGIK4bMvEwahf4ZGtAuMHF9vINNujvwknb6_1M74Ni0cg?testcase_id=5693838410907648
<script>
window.location = "http://xn--pckuas0o.com";</script>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 21 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 21 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta -M-55 M-56
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 27 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment