New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

RequestCoordinatorTest.SavePageLater failing on chromium.android/Lollipop Low-end Tester

Project Member Reported by perezju@chromium.org, Oct 20 2016

Issue description

components_unittests failing on chromium.android/Lollipop Low-end Tester

Looks like the test only recently started running on this bot, and is failing with:

I  230.213s run_tests_on_device(AG860440II6EAGC)  [ RUN      ] RequestCoordinatorTest.SavePageLater
I  230.213s run_tests_on_device(AG860440II6EAGC)  [ERROR:memory_mapped_file.cc(52)] Couldn't open /storage/sdcard0/chromium_tests_root/paks/content_shell.pak
I  230.213s run_tests_on_device(AG860440II6EAGC)  [ERROR:data_pack.cc(79)] Failed to mmap datapack
I  230.213s run_tests_on_device(AG860440II6EAGC)  ../../components/offline_pages/background/request_coordinator_unittest.cc:479: Failure
I  230.213s run_tests_on_device(AG860440II6EAGC)  Value of: immediate_schedule_callback_called()
I  230.213s run_tests_on_device(AG860440II6EAGC)    Actual: false
I  230.213s run_tests_on_device(AG860440II6EAGC)  Expected: true
I  230.213s run_tests_on_device(AG860440II6EAGC)  [  FAILED  ] RequestCoordinatorTest.SavePageLater (1 ms)
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4181/steps/components_unittests/logs/stdio

The build with the first failure has the likely related CL:

[Offline Pages] Add evaluation test support in RequestCoodinator.
1c1f5c1b9927576a524b1fe3476035f4d1128e79
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875cef2100560bcb9308e72742f7b5a00c2c66ab

commit 875cef2100560bcb9308e72742f7b5a00c2c66ab
Author: romax <romax@chromium.org>
Date: Fri Oct 21 01:26:29 2016

[Offline Page] Fix test failure on svelte devices.

The failure was because we weren't trying to run tests on low-end devices
and we weren't trying to do immediate scheduling on svelte devices. Adding
a call to the callback resolved the issue.

BUG= 657775 

Review-Url: https://chromiumcodereview.appspot.com/2433283003
Cr-Commit-Position: refs/heads/master@{#426676}

[modify] https://crrev.com/875cef2100560bcb9308e72742f7b5a00c2c66ab/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/875cef2100560bcb9308e72742f7b5a00c2c66ab/components/offline_pages/background/request_coordinator_unittest.cc

The test now succeeds, but we get (on this and a few other tests) error messages like:

I  266.062s run_tests_on_device(AG86044202EI2GC)  [ RUN      ] RequestCoordinatorTest.SavePageLater
I  266.062s run_tests_on_device(AG86044202EI2GC)  [ERROR:memory_mapped_file.cc(52)] Couldn't open /storage/sdcard0/chromium_tests_root/paks/content_shell.pak
I  266.062s run_tests_on_device(AG86044202EI2GC)  [ERROR:data_pack.cc(79)] Failed to mmap datapack
I  266.062s run_tests_on_device(AG86044202EI2GC)  [       OK ] RequestCoordinatorTest.SavePageLater (6 ms)
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4188/steps/components_unittests/logs/stdio

Is this expected?

Comment 3 by romax@chromium.org, Oct 25 2016

Sorry for the late reply, but seems like you also have those error messages in the first post. I'm not sure why it's there and I believe I've seen it before. Even though not sure if it's 'expected'.
I'll ask around and get back later.

Comment 4 by romax@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
I think those errors are always there... and the test failure has been fixed. hence closing the bug. please feel free to reopen if it's more than showing error messages.

Sign in to add a comment