New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657771 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : In md-history, Focus on checkbox appears in faint color than expected.

Reported by yfulgaon...@etouch.net, Oct 20 2016

Issue description

Chrome Version : 55.0.2883.21 (Official Build) b9eabca6f064bcaa5aa645e4b3eaba90cf47a43c-refs/branch-heads/2883@{#201} 64-bit
OS : Mac(10.10.5, 10.11.4, 10.11.5)

Precondition : Navigate to any web page to generate some history.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history page.
2. Check the checkbox of first history entry and press Tab key.
3. Now press ’Shift + Tab’ key and observe the focus on checkbox.

Actual : Focus on checkbox appears in faint color than expected.
Expected : Focus on checkbox should appear in slightly darker color such that the focus is clearly visible.

This is a regression issue broken in ‘M-55’, below is the Manual Regression range and will soon update bisect info.
Good build : 55.0.2851.0
Bad build : 55.0.2853.0

Note : This is Mac specific issue and the same is working fine on Windows and Linux OS.
 
Act_Exp_history_checkbox.png
72.0 KB View Download
Actual_history_checkbox.mov
2.5 MB Download
Expec_history_checkbox.mov
2.3 MB Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Working on bisect. will provide the info soon
Working on bisect. will provide the info soon

Comment 3 by hdodda@chromium.org, Oct 21 2016

Cc: hdodda@chromium.org
Labels: -hasbisect -Needs-Bisect hasbisect-per-revision
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build : 55.0.2859.0 (Revision : 418117)
Bad build : 55.0.2860.0 (Revision: 418438)

You are probably looking for a change made after 418186 (known good), but no later than 418187 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/bf072389f8d552d51f6c3426c4cc2dd1c9c069e3..b0b9fe38332b78ea9c1767619d3e8e6b96fbb76d

From the CL above, assigning the issue to the concern owner 

@dbeam - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2336503002

Thanks ! 

Comment 4 by hdodda@chromium.org, Oct 21 2016

Good and bad builds provided in comment #0 are not correct . 

Comment 5 by dbeam@chromium.org, Oct 25 2016

Labels: -Pri-1 -M-55 Pri-3
dbeam, do you think this is WAI?

We deliberately changed the color of the ripple to match the checkbox color in that CL, which explains the difference in the bug description. The only doubt I have is that maybe the new color is a bit too light and low-contrast.
Cc: tsergeant@chromium.org

Comment 8 by dbeam@chromium.org, Jul 6 2017

Owner: ----
I'm no longer working on Chrome, and unlikely to fix any bug I'm currently assigned.

So this bug doesn't languish, I'm unassigning myself.

Sign in to add a comment