Check Javascript streams implementation with Closure compiler |
|||||
Issue descriptionChromium has infrastructure to check Javascript files with the Closure compiler. See https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md This can be useful for finding bugs in our implementation, eg. issue 657743 . It can be run manually and is also run automatically by a try bot. Unfortunately, this is currently blocked by an issue with using Symbol types in the Closure compiler: https://github.com/google/closure-compiler/issues/1737 Other issues (probably solvable): * Closure complains that the file consists of a single statement with no side effects. It *is* pretty weird now that I think about it. * Closure is picking up another definition of ReadableStream from somewhere and complaining that we're redefining it. Other issues (A Small Matter Of Work): * Closure wants a definition of the v8 interface provided by V8 Extras.
,
Oct 23 2017
,
Nov 8 2017
Now that we have an eslint presubmit, there's probably little incremental benefit in using Closure as well. I'm tempted to close this, but I'll make it available in case someone else wants to pick it up.
,
Nov 8
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 9
We're going to provide type-safety and compile-time checking by porting the implementation to C++. See issue 902633. As such, this issue is obsolete. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Oct 20 2017Status: Untriaged (was: Available)