Issue 657743 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	ricea@chromium.org
Closed:	Oct 2016
Cc:	domenic@chromium.org
Components:	Blink>Network>StreamsAPI
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

ReadableStream getReader({mode: 'byob'}) fails with ReferenceError

Project Member Reported by ricea@chromium.org, Oct 20 2016

Issue description

Simple repro:

const rs = new ReadableStream();
rs.getReader({mode: 'byob'});

Throws error:
"ReferenceError: IsReadableByteStreamDefaultController is not defined"

BYOB reading isn't implemented yet, so this won't work anyway, but it should throw a TypeError in this case.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4abae818f5a6e89e539c091819f55d113cf2dc46

commit 4abae818f5a6e89e539c091819f55d113cf2dc46
Author: ricea <ricea@chromium.org>
Date: Thu Oct 20 11:55:09 2016

Fix ReadableStream getReader({mode: 'byob'})

getReader({mode: 'byob'}) failed with a ReferenceError. Make it throw a
TypeError instead.

BUG= 657743 

Review-Url: https://chromiumcodereview.appspot.com/2432863004
Cr-Commit-Position: refs/heads/master@{#426453}

[add] https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46/third_party/WebKit/LayoutTests/http/tests/streams/chromium/README.txt
[add] https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46/third_party/WebKit/LayoutTests/http/tests/streams/chromium/get-reader-byob.html
[modify] https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46/third_party/WebKit/Source/core/streams/ReadableStream.js

Comment 2 by ricea@chromium.org, Oct 20 2016

Status: Fixed (was: Started)

►

Issue 657743 link

Issue metadata

ReadableStream getReader({mode: 'byob'}) fails with ReferenceError

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 20 2016

Comment 1 Deleted

Comment 2 by ricea@chromium.org, Oct 20 2016

Comment 2 Deleted

Sign in to add a comment