Issue metadata
Sign in to add a comment
|
Regression: Glimpse of scrollbar is seen on 'On startup' section while zoom-out 'MD-Settings' page.
Reported by
dmascare...@etouch.net,
Oct 20 2016
|
||||||||||||||||||||
Issue descriptionChrome Version: 55.0.2883.21 Revision b9eabca6f064bcaa5aa645e4b3eaba90cf47a43c-refs/branch-heads/2883@{#201}(32/64 bit) OS: Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/onStartup,click on Advance link. 2. Press 'Ctrl -' and observe on startup section . Actual: Glimpse of scrollbar is seen beside iron icon of the urls. Expected: Glimpse of scrollbar should not be seen. This is regression issue, broken in 'M 54' and below is manual bisect: Good build:54.0.2832.0 Bad build:54.0.2833.0 Note: Issue is not seen on Mac and Linux OS.
,
Oct 21 2016
Using the per-revision bisect providing the bisect results, Good build:54.0.2832.0 (Revision: 412743) Bad build:54.0.2833.0 (Revision: 413134) You are probably looking for a change made after 413025 (known good), but no later than 413026 (first known bad). CHANGE-LOG URL: --------------------------------------- https://chromium.googlesource.com/chromium/src/+log/4bb66d2c936984bd48c541305d122a02a46ecc9a..feeb114ee91d6bb97f162f2c05f66f6d3ef84c15 From the CL above, assigning the issue to the concern owner @ stevenjb : ------------------ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2256753003
,
Oct 26 2016
Able to repro on chrome latest M55-55.0.2883.28. stevenjb@ - Can we get any latest update on this issue? if it's related to your change.
,
Oct 26 2016
-> dpapad@ who is investigating scrolling issues.
,
Nov 8 2016
,
Nov 10 2016
Briefly investigated this bug. At https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html?l=16, we set an explicit size to allow the iron-list to display exactly 6 elements. This calculation is very fragile because 1) It is place on #outer, instead of #container. #outer also contains two buttons at the bottom, not part of the iron-list. 2) When zooming in/out, borders lengths are slightly adjusted by Chrome, so the declared value of 1px is not true anymore, breaking the calculation and causing the scrollbar to appear. @dbeam: Do you have any ideas on how to make this robust, such that the iron-list displays always exactly 6 elements, regardless of zoom-level?
,
Nov 10 2016
,
Nov 10 2016
i don't think the 395px value matters. it's that the browser is bumping up against that max-height while zoom is changing that is weird to me. I'd also be interested in why we'd like to show exactly 6 items.
,
Nov 14 2016
Searching through code history, showing 6 items landed at https://chromium.googlesource.com/chromium/src/+/72679618a08ccd653fcca4efab460a5b2ebf0eac. Perhaps @dschuyler knows why it was chosen.
,
Nov 14 2016
It was an aesthetic call by Alan. (That's why the CL description says "This was requested by Alan"). I'm confident that it can be changed without too much concern from Alan - as long as it looks good. Before that change, iirc, the list was unlimited. Alan nor I liked it being unlimited and Alan said six was a good place to limit the list. Six rows was not a magic, special number. If there's another limit (or way to limit the list) that looks good and works better - I say go for it (and I'm 99% confident Alan will say so as well). +cc/bettes@ in case I'm off on predicting Alan's opinion.
,
Nov 14 2016
Thanks for the context. The issue AFAIU is not the exact X number of items to show by default, but the fact that correctly calculating the height of the list such that there are exactly X items shown at different zoom levels, without causing a scrollbar to flash while transitioning through zoom-levels, seems fragile.
,
Nov 14 2016
The 395px value came our of that context. While there were no obvious issues with setting that value at the time, I understand that an issue was found. I'd like to learn how to make this work better too. I'm keen on hearing more from this question in #6 > @dbeam: Do you have any ideas on how to make this robust, such that the iron-list displays always exactly 6 elements, regardless of zoom-level? In case it helps: We had another issue show up in a different list (sorry I don't have a bug link) where showing an exact N rows made it hard to see that there were more items in the list (on Mac specifically, where the scroll bar will not be visible sometimes). In that case, the workaround was to show five and a half rows. Where that information could help this bug is: We may not want to show a carefully calculated exact number of rows. We may do well to err on the side of showing a smaller box if it proves difficult to calculate an exact value.
,
Nov 22 2016
Just to to update the latest behavior of the bug, Issue is still observed on chrome latest Canary M57-57.0.2926.0 dpapad@ Could you please let us know is there any recent update available on this issue? Thanks!
,
Nov 22 2016
,
Jan 31 2017
,
Oct 24 2017
Marking bugs (mostly lower priority ones) that I am unlikely to get to soon as Available.
,
Oct 25
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Oct 20 2016Status: Untriaged (was: Unconfirmed)