New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657733 link

Starred by 18 users
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jul 2017
Cc:
█ srcv@chromium.org
tommi@chromium.org
amistry@chromium.org
guidou@chromium.org
emir...@chromium.org
braveyao@chromium.org
nisse@chromium.org
█ perkj@chromium.org
mcasas@chromium.org
█ mu...@chromium.org
hta@chromium.org
█ magjed@chromium.org
rohi...@chromium.org
█ vrk@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 648183
issue 711234
issue 720025
Blocking:
issue 842877
issue webrtc:4906
issue 543997
issue 623601
issue 682887



Sign in to add a comment

Implement selectSettings algorithm for MediaStreamTrack constraint resolution

Project Member Reported by guidou@chromium.org, Oct 20 2016 
Currently, Chrome supports the new spec syntax for constraints, but it does not fully implement the SelectSettings algorithm as specified in https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia.

This bug tracks the development of this feature, which is required for fully spec-compliant getUsermedia() and applyConstraints().

Comment 1 by guidou@chromium.org, Dec 1 2016 

 Issue 657145  has been merged into this issue.

Comment 2 by guidou@chromium.org, Dec 5 2016

Cc: rohi...@chromium.org srcv@chromium.org amistry@chromium.org tommi@chromium.org mu...@chromium.org
Issue 564574 has been merged into this issue.

Comment 4 by hta@chromium.org, Jan 11 2017

Blocking: webrtc:4096

Comment 5 by hta@chromium.org, Jan 11 2017

Blocking: -webrtc:4096 webrtc:4906

Comment 6 by guidou@chromium.org, Jan 13 2017

Cc: vrk@chromium.org perkj@chromium.org magjed@chromium.org mcasas@chromium.org
 Issue 273052  has been merged into this issue.

Comment 7 by hta@chromium.org, Jan 20 2017

Blocking: 682887
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a440b84693ff261a07858d64655f90c285359fb

commit 8a440b84693ff261a07858d64655f90c285359fb
Author: guidou <guidou@chromium.org>
Date: Mon Jan 30 13:58:43 2017

Add IPC to query capabilities of video input devices.

This IPC is intended to support new spec-compliant functionality for getUserMedia
such as device and settings selection based on constraints, and the applyConstraints
function.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2646833002
Cr-Commit-Position: refs/heads/master@{#446977}

[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/BUILD.gn
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/frame_host/render_frame_host_delegate.h
[add] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/media/media_devices_util.cc
[add] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/media/media_devices_util.h
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/media_devices_dispatcher_host.h
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/video_capture_manager.h
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/common/media/media_devices.mojom
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/renderer/media/media_devices_event_dispatcher_unittest.cc
[modify] https://crrev.com/8a440b84693ff261a07858d64655f90c285359fb/content/renderer/media/user_media_client_impl_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/983f3e3990d1048b85275d7b455ca6ca78bf5e23

commit 983f3e3990d1048b85275d7b455ca6ca78bf5e23
Author: guidou <guidou@chromium.org>
Date: Wed Feb 08 12:34:32 2017

Spec-compatible algorithm for selecting video source and settings.

This is a step towards providing spec-compliant constraints support
for getUserMedia and applyConstraints.

This CL will be followed by two CLs to integrate the algorithm into Chromium.

1. A CL that uses this algorithm to select the correct video-capture device in
   getUserMedia (settings will still be chosen with the old algorithm).

2. A CL that replaces the existing algorithm for video-source settings in
   getUserMedia with the spec-compliant one.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2668023002
Cr-Commit-Position: refs/heads/master@{#448966}

[modify] https://crrev.com/983f3e3990d1048b85275d7b455ca6ca78bf5e23/content/renderer/BUILD.gn
[add] https://crrev.com/983f3e3990d1048b85275d7b455ca6ca78bf5e23/content/renderer/media/media_stream_constraints_util_video_source.cc
[add] https://crrev.com/983f3e3990d1048b85275d7b455ca6ca78bf5e23/content/renderer/media/media_stream_constraints_util_video_source.h
[add] https://crrev.com/983f3e3990d1048b85275d7b455ca6ca78bf5e23/content/renderer/media/media_stream_constraints_util_video_source_unittest.cc
[modify] https://crrev.com/983f3e3990d1048b85275d7b455ca6ca78bf5e23/content/test/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e

commit 9ea409c2a23810063bb280304e18b48dc6b0fe7e
Author: guidou <guidou@chromium.org>
Date: Wed Feb 08 13:54:11 2017

Use spec-compliant algorithm to select video devices in getUserMedia.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2669243004
Cr-Commit-Position: refs/heads/master@{#448981}

[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/media_stream_dispatcher.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/media_stream_dispatcher.h
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/media_stream_dispatcher_unittest.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/mock_media_stream_dispatcher.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/mock_media_stream_dispatcher.h
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9ea409c2a23810063bb280304e18b48dc6b0fe7e/extensions/browser/guest_view/app_view/app_view_apitest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9684dde3d74662e43ec427afd9ab55c8d6138d

commit 7e9684dde3d74662e43ec427afd9ab55c8d6138d
Author: perezju <perezju@chromium.org>
Date: Fri Feb 10 13:34:57 2017

Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #2 id:80001 of https://codereview.chromium.org/2669243004/ )

Reason for revert:
Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest https://crbug.com/690626

Original issue's description:
> Use spec-compliant algorithm to select video devices in getUserMedia.
>
> BUG= 657733 
>
> Review-Url: https://codereview.chromium.org/2669243004
> Cr-Commit-Position: refs/heads/master@{#448981}
> Committed: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 657733 

Review-Url: https://codereview.chromium.org/2684233005
Cr-Commit-Position: refs/heads/master@{#449605}

[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/media_stream_dispatcher.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/media_stream_dispatcher.h
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/media_stream_dispatcher_unittest.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/mock_media_stream_dispatcher.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/mock_media_stream_dispatcher.h
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7e9684dde3d74662e43ec427afd9ab55c8d6138d/extensions/browser/guest_view/app_view/app_view_apitest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a46c315b7a01905c6509ec51b572cb89209a50

commit 28a46c315b7a01905c6509ec51b572cb89209a50
Author: guidou <guidou@chromium.org>
Date: Mon Feb 13 18:38:04 2017

Reland of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )

Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #2 id:80001 of https://codereview.chromium.org/2669243004/ )
>
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest https://crbug.com/690626
>
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> >
> > BUG= 657733 
> >
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e
>
> TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 657733 
>
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed: https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9ab55c8d6138d

In addition to the original patch, make the failing test use fake media devices to ensure that there is always at least one device of each kind. Without devices, the spec-compliant getUserMedia() will fail without asking for permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 657733 ,690626

Review-Url: https://codereview.chromium.org/2696443002
Cr-Commit-Position: refs/heads/master@{#450026}

[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/media_stream_dispatcher.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/media_stream_dispatcher.h
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/media_stream_dispatcher_unittest.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/mock_media_stream_dispatcher.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/mock_media_stream_dispatcher.h
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/28a46c315b7a01905c6509ec51b572cb89209a50/extensions/browser/guest_view/app_view/app_view_apitest.cc

Comment 14 by braveyao@chromium.org, Feb 13 2017

Cc: braveyao@chromium.org
The patch in #13 will still fail the getUserMedia request from appr.tc and other webrtc samples on Android. (the one in #11 used to fail on all platforms)
You can refer the  issue691559  for the error. Same in ToT Chromium, as #450095 in my test.

Comment 15 by guidou@chromium.org, Feb 15 2017 

braveyao: can you check if non-Android platforms still break? 
#13 and #11 are identical, except for a fix to a Webview test that depended on nonstandard behavior.
The fix for  issue 691559  fixed the Android problems. Maybe other platforms had the same issue?

Comment 16 by braveyao@chromium.org, Feb 15 2017 

No. The patch in #11 did cause gUM problem on all platforms. But the patch #450026 in #13 works fine on non-Android platforms. The ToT works on all platforms now. 
Maybe it's due to the different failure reason. On Android it's DeviceNotFound. On other platforms(as I can remember) it's about track creation failure...
You may need to double check :)

Comment 17 by guidou@webrtc.org, Feb 17 2017

Blocking: webrtc:4819
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3badfc1687f2db393cec360febe0dbcf38522447

commit 3badfc1687f2db393cec360febe0dbcf38522447
Author: guidou <guidou@chromium.org>
Date: Fri Feb 24 15:46:35 2017

Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

5. Move the Settings type to the .cc file. Work with modules in follow-up CLs has shown that it is more convenient to return the result in the types that are expected by other content classes rather than introduce a new class that will need to be translated. (e.g., translating from Settings to media::VideoCaptureParams).

BUG= 657733 

Review-Url: https://codereview.chromium.org/2707203006
Cr-Commit-Position: refs/heads/master@{#452834}

[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/BUILD.gn
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_constraints_util.h
[rename] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_constraints_util_video_device.cc
[rename] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_constraints_util_video_device.h
[rename] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_constraints_util_video_device_unittest.cc
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/media_stream_video_track.cc
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/3badfc1687f2db393cec360febe0dbcf38522447/content/test/BUILD.gn

Comment 19 by guidou@chromium.org, Feb 27 2017

Cc: nisse@chromium.org emir...@chromium.org guidou@chromium.org
 Issue 623104  has been merged into this issue.
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4341272631c917395e82ff2cea99098b9eaded

commit 1c4341272631c917395e82ff2cea99098b9eaded
Author: guidou <guidou@chromium.org>
Date: Wed Mar 01 16:00:56 2017

Patch constraints algorithm for device video-capture sources.

The original algorithm did not correctly handle cases of contradicting
advanced constraint sets for source settings that support a range of values
(i.e., height, width and frame rate).

This patch fixes this glitch, fixes two existing tests and adds new
tests.

Thanks hbos@ for noticing this glitch in a previous review.

BUG= 657733 

some good progress

Review-Url: https://codereview.chromium.org/2719153002
Cr-Commit-Position: refs/heads/master@{#453941}

[modify] https://crrev.com/1c4341272631c917395e82ff2cea99098b9eaded/content/renderer/media/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/1c4341272631c917395e82ff2cea99098b9eaded/content/renderer/media/media_stream_constraints_util_video_device_unittest.cc

Comment 30 by chfremer@chromium.org, Mar 9 2017

Blocking: 623601
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca03688be282be7b59aadc46489823e9ebcf3bd

commit 2ca03688be282be7b59aadc46489823e9ebcf3bd
Author: guidou <guidou@chromium.org>
Date: Wed Mar 15 23:53:02 2017

Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2751643003
Cr-Commit-Position: refs/heads/master@{#457268}

[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/media_stream_constraints_util_video_content.h
[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/media_stream_constraints_util_video_device.h
[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/media_stream_constraints_util_video_device_unittest.cc
[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/2ca03688be282be7b59aadc46489823e9ebcf3bd/content/renderer/media/user_media_client_impl.h
Project Member

Comment 35 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d727ed27c3dde3c85195625b97e79472eda73508

commit d727ed27c3dde3c85195625b97e79472eda73508
Author: guidou <guidou@chromium.org>
Date: Tue Mar 21 21:42:43 2017

Serialize processing of getUserMedia() requests.

This is in anticipation to using the spec-compliant algorithm for
constraints processing.
The standard algorithm requires knowing the capabilities of all devices
before selecting the settings to be used. If two requests are processed
in parallel this can lead to races that would result in unexpected
errors. For example, there may be two requests that require the same
camera but prefer (though not require) different resolutions.
If the requests are handled in parallel and the camera has not been
opened yet, both requests will see that all resolutions are supported
and both will try to open the camera with different resolutions and one
of the requests will fail unxpectedly.
If the requests are handled sequentially, the camera will be opened with
the resolution selected by the first request, and the second request will
see that that resolution is the only available one. If that resolution
satisfies the constraints for the second request, the request will
succeed. Otherwise, it will fail in a spec-compliant way.

This CL also includes:
* A minor refactoring to expose fewer implementation details to the
  unit test.
* Removal of some unnecessary includes and logging statements.
* More consistent naming of variables. request_info for
  UserMediaRequestInfo and request or user_media_request for
  WebUserMediaRequest.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2764043002
Cr-Commit-Position: refs/heads/master@{#458560}

[modify] https://crrev.com/d727ed27c3dde3c85195625b97e79472eda73508/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/d727ed27c3dde3c85195625b97e79472eda73508/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/d727ed27c3dde3c85195625b97e79472eda73508/content/renderer/media/user_media_client_impl_unittest.cc
Project Member

Comment 37 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff69cf4c3028e0bb4e15c78b137c6bb26966974

commit eff69cf4c3028e0bb4e15c78b137c6bb26966974
Author: guidou <guidou@chromium.org>
Date: Wed Mar 29 16:00:29 2017

Introduce SelectSettings algorithm for MediaStream video tracks.

This CL also:
* Renames functions and types related to selecting settings, dropping
  "Source" from the name, since now they also deal with track settings.
* Introduces a VideoTrackAdapterSettings struct to pass arguments to
  VideoTrackAdapter and to return track settings in a more convenient
  manner.
* Use a single class VideoCaptureSettings for the results of both
  content and device capture. They differed only in the facing_mode
  field.
* The default width and height in
  ResolutionSet::SelectClosestPointToIdeal are passed as parameters
  instead of using MediaStreamVideoSource constants. This gives more
  flexibility, such as allowing the use of source settings as defaults.
* Makes default width and height constants for content capture public.
  This is a first step towards better defaults for screen capture. See
   http://crbug.com/257097 .
* Reimplements the internal ConstrainedFormat class in
  media_stream_constraints_util_video_device.cc so in terms of
  ResolutionSet and NumericRangeSet. This removes code that is largely
  duplicated and facilitates integration with the code that computes
  track settings.
* Replaces rtc::Optional with base::Optional.
* Makes minor changes to be more consistent with other parts of the
  codebase (e.g., some constexpr changed to const), or to better
  express intent.
* Fixes minor lint issues in existing source files.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2777703002
Cr-Commit-Position: refs/heads/master@{#460403}

[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util.h
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_sets.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_sets.h
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_sets_unittest.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_unittest.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_content.h
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_device.h
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_constraints_util_video_device_unittest.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/video_track_adapter.cc
[modify] https://crrev.com/eff69cf4c3028e0bb4e15c78b137c6bb26966974/content/renderer/media/video_track_adapter.h
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6

commit 9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6
Author: guidou <guidou@chromium.org>
Date: Wed Apr 05 21:29:24 2017

Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2787773002
Cr-Commit-Position: refs/heads/master@{#462223}

[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/chrome/renderer/media/cast_receiver_session.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/renderer/media_capture_from_element/html_video_element_capturer_source.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/renderer/media_capture_from_element/html_video_element_capturer_source.h
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/media/capture/video_capturer_source.cc
[modify] https://crrev.com/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6/media/capture/video_capturer_source.h
Project Member

Comment 40 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634

commit 7f1e2a9882f033206ffac41e8f1b5b0ee7aee634
Author: guidou <guidou@chromium.org>
Date: Thu Apr 06 10:41:23 2017

Spec compliant video constraints for getUserMedia behind flag.

The core of this CL is a modification to classes that currently
process constraints (but shouldn't):
- UserMediaClientImpl
- MediaStreamVideoSource
- MediaStreamVideoCapturerSource
- MediaStreamVideoWebRtcSink

With this CL these classes, when a flag is enabled, instead of processing
constraints, they process settings previously produced by a spec-compliant
constraints-processing algorithm.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2790823002
Cr-Commit-Position: refs/heads/master@{#462417}

[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/public/common/content_features.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/public/common/content_features.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_center.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_constraints_util.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_source.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_track.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_track.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/mock_media_stream_registry.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/mock_media_stream_video_source.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/mock_media_stream_video_source.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/video_track_adapter.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/video_track_adapter.h
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/media_recorder/video_track_recorder_unittest.cc
[modify] https://crrev.com/7f1e2a9882f033206ffac41e8f1b5b0ee7aee634/content/renderer/pepper/pepper_media_stream_video_track_host.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501bc50c7265030e4873ce16b3e583a50fd5b558

commit 501bc50c7265030e4873ce16b3e583a50fd5b558
Author: guidou <guidou@chromium.org>
Date: Thu Apr 06 11:27:28 2017

Clone MediaStream video tracks correctly with spec-compliant constraints.

The old algorithm copied constraints to the source, and used them for
cloning.
With the new algorithm, sources know about source settings and tracks
about track settings. This CL copies settings from the original track
to the clone.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2791303002
Cr-Commit-Position: refs/heads/master@{#462424}

[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/content/renderer/media/media_stream_center.cc
[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/content/renderer/media/media_stream_center.h
[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp
[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.h
[modify] https://crrev.com/501bc50c7265030e4873ce16b3e583a50fd5b558/third_party/WebKit/public/platform/WebMediaStreamCenter.h
Project Member

Comment 42 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08

commit 8f48e5edcd8494a2b8ec8e45c49eecf7039feb08
Author: miu <miu@chromium.org>
Date: Wed Apr 12 03:08:31 2017

Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ )

Reason for revert:
Regressed performance_browser_tests 21-93% (see  crbug.com/710187 ). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead.

Original issue's description:
> Enable spec-compliant algorithm for MediaStream video constraints by default
>
> BUG= 657733 
>
> Review-Url: https://codereview.chromium.org/2793053002
> Cr-Commit-Position: refs/heads/master@{#462575}
> Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42

TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 657733 

Review-Url: https://codereview.chromium.org/2810913007
Cr-Commit-Position: refs/heads/master@{#463913}

[modify] https://crrev.com/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08/content/public/common/content_features.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bc11efe0ad6275747cb848e083051409b5144b2

commit 8bc11efe0ad6275747cb848e083051409b5144b2
Author: guidou <guidou@chromium.org>
Date: Wed Apr 12 03:31:14 2017

Reland of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #1 id:1 of https://codereview.chromium.org/2810913007/ )

Reason for revert:
The defaults were changed to the same as the old algorithm in subsequent patches.

Original issue's description:
> Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ )
>
> Reason for revert:
> Regressed performance_browser_tests 21-93% (see  crbug.com/710187 ). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead.
>
>
> Original issue's description:
> > Enable spec-compliant algorithm for MediaStream video constraints by default
> >
> > BUG= 657733 
> >
> > Review-Url: https://codereview.chromium.org/2793053002
> > Cr-Commit-Position: refs/heads/master@{#462575}
> > Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42
>
> TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 657733 
>
> Review-Url: https://codereview.chromium.org/2810913007
> Cr-Commit-Position: refs/heads/master@{#463913}
> Committed: https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08

TBR=avi@chromium.org,stkhapugin@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 657733 

Review-Url: https://codereview.chromium.org/2816533003
Cr-Commit-Position: refs/heads/master@{#463919}

[modify] https://crrev.com/8bc11efe0ad6275747cb848e083051409b5144b2/content/public/common/content_features.cc
Project Member

Comment 44 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7eaf476075d774e835fc0310be0557ccf4b2b9e

commit d7eaf476075d774e835fc0310be0557ccf4b2b9e
Author: guidou <guidou@chromium.org>
Date: Wed Apr 12 07:05:10 2017

Revert "Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #1 id:1 of https://codereview.chromium.org/2810913007/ )"

This reverts commit 8bc11efe0ad6275747cb848e083051409b5144b2.
This reverts an accidental reland.

BUG= 657733 
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=

Review-Url: https://codereview.chromium.org/2810143002
Cr-Commit-Position: refs/heads/master@{#463939}

[modify] https://crrev.com/d7eaf476075d774e835fc0310be0557ccf4b2b9e/content/public/common/content_features.cc
Project Member

Comment 45 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02fcf46036643c6c896c059161f2a2b6aa8e6c6b

commit 02fcf46036643c6c896c059161f2a2b6aa8e6c6b
Author: guidou <guidou@chromium.org>
Date: Wed Apr 12 17:31:14 2017

Update constraints algorithm for screen capture.

If explicit frame rate is given, use that as default. This is more
compatible with existing tests and applications and is still spec
compliant. This fixes a regression.

Use media::limits::kMaxDimension/2 (16383) as maximum screencast
dimension. The older value could produce results that exceed the
maximum canvas size, which is 16384 x 16384 - 1.

Properly use explicit maximum dimensions and frame rate as default in
screen capture. An older fix for dimensions had a bug when the maximum
allowed values coincided with explicitly given max constraints.

BUG= 657733 , 710187 

Review-Url: https://codereview.chromium.org/2814063002
Cr-Commit-Position: refs/heads/master@{#464068}

[modify] https://crrev.com/02fcf46036643c6c896c059161f2a2b6aa8e6c6b/content/renderer/media/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/02fcf46036643c6c896c059161f2a2b6aa8e6c6b/content/renderer/media/media_stream_constraints_util_video_content.h
[modify] https://crrev.com/02fcf46036643c6c896c059161f2a2b6aa8e6c6b/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4a75996a93114e8b6af4a28849c0f4db43347e1

commit d4a75996a93114e8b6af4a28849c0f4db43347e1
Author: guidou <guidou@chromium.org>
Date: Wed Apr 12 17:58:20 2017

Reland of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #1 id:1 of https://codereview.chromium.org/2810913007/ )

Reason for revert:
The fix for the issue has landed.

Original issue's description:
> Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ )
>
> Reason for revert:
> Regressed performance_browser_tests 21-93% (see  crbug.com/710187 ). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead.
>
>
> Original issue's description:
> > Enable spec-compliant algorithm for MediaStream video constraints by default
> >
> > BUG= 657733 
> >
> > Review-Url: https://codereview.chromium.org/2793053002
> > Cr-Commit-Position: refs/heads/master@{#462575}
> > Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42
>
> TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 657733 
>
> Review-Url: https://codereview.chromium.org/2810913007
> Cr-Commit-Position: refs/heads/master@{#463913}
> Committed: https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08

TBR=avi@chromium.org,stkhapugin@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 657733 

Review-Url: https://codereview.chromium.org/2814813004
Cr-Commit-Position: refs/heads/master@{#464081}

[modify] https://crrev.com/d4a75996a93114e8b6af4a28849c0f4db43347e1/content/public/common/content_features.cc

Comment 47 by aleksand...@intel.com, Apr 13 2017

Blockedon: 711234

Comment 48 by guidou@chromium.org, May 9 2017

Blockedon: 720025
Project Member

Comment 49 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7

commit 5c25608ed9478c41bdcabad1fbea6cd85a6e89e7
Author: guidou <guidou@chromium.org>
Date: Mon May 15 15:50:55 2017

Add ability to retrieve capabilities for audio input devices to MediaDevicesDispatcherHost.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2868853002
Cr-Commit-Position: refs/heads/master@{#471774}

[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/browser/renderer_host/media/media_devices_dispatcher_host.h
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/common/media/media_devices.mojom
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/renderer/media/media_devices_event_dispatcher_unittest.cc
[modify] https://crrev.com/5c25608ed9478c41bdcabad1fbea6cd85a6e89e7/content/renderer/media/user_media_client_impl_unittest.cc

Comment 50 by roy...@google.com, Jun 8 2017

Labels: Hotlist-Enterprise Proj-Hotrod
Project Member

Comment 51 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e98fac1dfdffcd0c04639bc60aedd97a272ae9

commit 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Jun 12 14:08:40 2017

SelectSettings algorithm for audio constraints.

This is intended to be used in getUserMedia to implement spec-compliant
audio constraints processing.

BUG= 657733 

Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
Reviewed-on: https://chromium-review.googlesource.com/517782
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478607}
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/BUILD.gn
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util.h
[add] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_audio.cc
[add] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_audio.h
[add] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_sets.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_sets.h
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/renderer/media/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/content/test/BUILD.gn
[modify] https://crrev.com/51e98fac1dfdffcd0c04639bc60aedd97a272ae9/third_party/WebKit/public/platform/WebMediaConstraints.h
Project Member

Comment 52 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42f379d3edefabc6f9afe841454937b8af583d81

commit 42f379d3edefabc6f9afe841454937b8af583d81
Author: Devlin <rdevlin.cronin@chromium.org>
Date: Mon Jun 12 16:01:10 2017

Revert "SelectSettings algorithm for audio constraints."

This reverts commit 51e98fac1dfdffcd0c04639bc60aedd97a272ae9.

Reason for revert: New tests (MediaStreamConstraintsUtilAudioTest.ValidGeometry) are failing:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F60774%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Flogs%2FMediaStreamConstraintsUtilAudioTest.ValidGeometry__x2f_0%2F0

Original change's description:
> SelectSettings algorithm for audio constraints.
> 
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
> 
> BUG= 657733 
> 
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478607}

TBR=miu@chromium.org,hbos@chromium.org,guidou@chromium.org,jochen@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 657733 

Change-Id: I9c9e9f6a9b0ad464c550443e273409feb4bd6ec7
Reviewed-on: https://chromium-review.googlesource.com/531126
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478643}
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/BUILD.gn
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util.h
[delete] https://crrev.com/8777982503bdf20d27992ded417d64b8a2be081e/content/renderer/media/media_stream_constraints_util_audio.cc
[delete] https://crrev.com/8777982503bdf20d27992ded417d64b8a2be081e/content/renderer/media/media_stream_constraints_util_audio.h
[delete] https://crrev.com/8777982503bdf20d27992ded417d64b8a2be081e/content/renderer/media/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util_sets.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util_sets.h
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/renderer/media/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/content/test/BUILD.gn
[modify] https://crrev.com/42f379d3edefabc6f9afe841454937b8af583d81/third_party/WebKit/public/platform/WebMediaConstraints.h
Project Member

Comment 53 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860dd9ed86a08dbdd234f0d89f6e53a079a683b3

commit 860dd9ed86a08dbdd234f0d89f6e53a079a683b3
Author: guidou <guidou@chromium.org>
Date: Mon Jun 26 14:50:55 2017

Enable new getUserMedia audio constraints algorithm behind a flag.

BUG= 657733 

Review-Url: https://codereview.chromium.org/2941563002
Cr-Commit-Position: refs/heads/master@{#482273}

[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/public/common/content_features.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/public/common/content_features.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/media_stream_audio_processor.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/media_stream_audio_processor.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/video_track_adapter.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/webrtc/processed_local_audio_source.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/webrtc/processed_local_audio_source.h
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[add] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/extensions/browser/guest_view/web_view/DEPS
[modify] https://crrev.com/860dd9ed86a08dbdd234f0d89f6e53a079a683b3/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
Project Member

Comment 54 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68360310a67c402b76f1fea6a664c6a284b73c4e

commit 68360310a67c402b76f1fea6a664c6a284b73c4e
Author: guidou <guidou@chromium.org>
Date: Fri Jun 30 05:09:59 2017

Enable spec-compliant getUserMedia audio constraints algorithm by default

BUG= 657733 

Review-Url: https://codereview.chromium.org/2933413002
Cr-Commit-Position: refs/heads/master@{#483638}

[modify] https://crrev.com/68360310a67c402b76f1fea6a664c6a284b73c4e/content/public/common/content_features.cc

Comment 55 by guidou@chromium.org, Jul 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment