New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657718 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression: [MD Settings] Weird behavior of settings page is seen on pressing Left/Right arrow key.

Reported by dchau...@etouch.net, Oct 20 2016

Issue description

Chrome Version: 55.0.2883.21 (Official Build)b9eabca6f064bcaa5aa645e4b3eaba90cf47a43c-refs/branch-heads/2883@{#201} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings page.
2. Scroll down the page and click on 'Advanced' button.
3. Now, press Left/Right arrow key from keyboard and observe.

On pressing Left/Right arrow key, Unnecessary content of page moves left/right even horizontal bar is not present on the page.
On pressing Left/Right arrow key, Content of settings page should not move left/right.

This is a regression issue, broken in M-55 series, below is manual regression range.

Good build: 55.0.2875.0
Bad build: 55.0.2876.0

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
708 KB View Download
Labels: Proj-MaterialDesign-WebUI Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Working on bisect. will provide the info soon
Cc: jmukthavaram@chromium.org
Labels: -hasbisect -Needs-Bisect hasbisect-per-revision
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on windows 7,Linux Ubuntu 14.04 & Mac 10.11.4.Please find the below bisect information.

Manual Bisect:
-------------------
Good build: 55.0.2875.0---421703
Bad build: 55.0.2876.0---421986

Bisect Tool Info:

CL-
--------------------
https://chromium.googlesource.com/chromium/src/+log/a411fd062bc68fc2b5fc3aca7e4cbb8e4a3e074e..0527e2bfcc1847ed80e3ddd6c0b25cbcc555b4b9

Possible suspect:
---------------------
https://chromium.googlesource.com/chromium/src/+/0527e2bfcc1847ed80e3ddd6c0b25cbcc555b4b9

Review-Url:
---------------------
https://codereview.chromium.org/2379933003
 
 dbeam@assigning to you,Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!

Comment 3 by dbeam@chromium.org, Oct 26 2016

Cc: dbeam@chromium.org esprehn@chromium.org szager@chromium.org
Owner: ----
hey look, /another/ overflow: overlay issue :(
Just to update the latest behavior of the bug, Issue is still observed on chrome version 55.0.2883.52.
dev team@ Could you please let us know is there any recent update available on this issue? 

Thanks!
 Issue 662726  has been merged into this issue.
Gentle Ping! Could anyone let us know is there any latest update available for this issue.

Comment 7 by dbeam@chromium.org, Nov 29 2016

Cc: -szager@chromium.org ojan@chromium.org
Labels: -M-55
Owner: szager@chromium.org
pretty sure this is an overflow: overlay issue

Comment 8 by tbuckley@google.com, Jan 25 2017

Blocking: 671375
Labels: Hotlist-MD-Settings-Structure
szager@ - I can reproduce this on a pixel if you would like to see it.

I was able to confirm that reverting https://codereview.chromium.org/2379933003 (removing 'overflow-y: overlay' from the top level settings-ui element) does remove this problem.

@szager any updates?
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a729d1bc790d94120ec942a4566bb85f969cdb1

commit 5a729d1bc790d94120ec942a4566bb85f969cdb1
Author: szager <szager@chromium.org>
Date: Wed Mar 01 23:56:33 2017

Account for overlay scrollbars when computing scrollbar width/height.

This specifically addresses overlay scrollbars created via css with
overflow:overlay.  In some places, those scrollbars are treated
differently from overlay scrollbars created by the platform theme
(e.g., on mac).

BUG= 657718 
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2725763002
Cr-Commit-Position: refs/heads/master@{#454105}

[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/5a729d1bc790d94120ec942a4566bb85f969cdb1/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

Comment 12 by ojan@chromium.org, Mar 7 2017

Cc: -ojan@chromium.org
Owner: tbuck...@chromium.org
tbuckley@: is this fixed?
Cc: szager@chromium.org
 Issue 691189  has been merged into this issue.
Tested this in Chrome 59.0.3033.0 (Windows 10), working correctly now.
Status: Fixed (was: Assigned)
Yep, this seems fixed on 59.0.3039.0 canary (Chrome OS) with both regular and overlay scrollbars. Closing this bug.

Sign in to add a comment