Issue metadata
Sign in to add a comment
|
LaunchDateAndTimeSettingsOnFile DCHECK in CalledOnValidThread |
||||||||||||||||||||||
Issue descriptionLaunchDateAndTimeSettingsOnFile(), used in interstitials like the Bad Clock SSL error, causes a crash in Debug (e.g. in a test image): [74660:74679:1019/225750:FATAL:browser_process_impl.cc(560)] Check failed: CalledOnValidThread(). #0 0x7f46390be42e base::debug::StackTrace::StackTrace() #1 0x7f46390df04a logging::LogMessage::~LogMessage() #2 0x7f463a6abb86 BrowserProcessImpl::profile_manager() #3 0x7f463a5478dc ProfileManager::GetActiveUserProfile() #4 0x7f463a7da46e (anonymous namespace)::LaunchDateAndTimeSettingsOnFile() #5 0x7f46390bef46 base::debug::TaskAnnotator::RunTask() #6 0x7f46390ea70d base::MessageLoop::RunTask() #7 0x7f46390eaa78 base::MessageLoop::DeferOrRunPendingTask() #8 0x7f46390eae8b base::MessageLoop::DoWork() #9 0x7f46390ed8c9 base::MessagePumpLibevent::Run() #10 0x7f46390ea419 base::MessageLoop::RunHandler() #11 0x7f4639116cd0 base::RunLoop::Run() #12 0x7f463914e8ae base::Thread::Run() #13 0x7f4636b8f665 content::BrowserThreadImpl::FileThreadRun() #14 0x7f4636b8f9c1 content::BrowserThreadImpl::Run() #15 0x7f463914ed33 base::Thread::ThreadMain() #16 0x7f46391477fc base::(anonymous namespace)::ThreadFunc() #17 0x7f463920c184 start_thread #18 0x7f462f89b37d clone
,
Oct 31 2016
LaunchDateAndTimeSettingsOnFile runs on File thread but it access BrowserProcessImpl::profile_manager which runs on IO (I guess). I don't think it's necessary to post to File thread on ChromeOS, as we are simply displaying a chrome:// page there.
,
Oct 31 2016
> which runs on IO (I guess) s/IO/UI
,
Oct 31 2016
Patch at https://codereview.chromium.org/2459193003
,
Nov 1 2016
This was on Chrome OS, using one of the latest samus images available. I repro'd by completing OOBE, manually changing the date and time follow similar steps to issue 506190, and opening Guest Mode and trying to visit an SSL site like google.com.
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c14f57a9d1d19685e64b692ee7259dd4eabd01f7 commit c14f57a9d1d19685e64b692ee7259dd4eabd01f7 Author: meacer <meacer@chromium.org> Date: Wed Nov 02 01:47:38 2016 Open ChromeOS clock settings on the UI thread instead of File. ChromeOS clock settings code accesses BrowserProcessImpl::profile_manager() which should be accessed on the UI thread. Since this code is simply opening a new window, there is no need to run it on a different thread. BUG= 657704 TEST=Manual, change system clock, go to https://expired.badssl.com and launch clock settings. Review-Url: https://codereview.chromium.org/2459193003 Cr-Commit-Position: refs/heads/master@{#429182} [modify] https://crrev.com/c14f57a9d1d19685e64b692ee7259dd4eabd01f7/chrome/browser/interstitials/chrome_controller_client.cc
,
Nov 2 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nparker@chromium.org
, Oct 31 2016Labels: Needs-Feedback