New issue
Advanced search Search tips

Issue 657672 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Assertion error when viewing details of a CUPS printer.

Project Member Reported by dpa...@chromium.org, Oct 20 2016

Issue description

See screenshot at http://imgur.com/a/s6CuJ.
 

Comment 1 by dpa...@chromium.org, Oct 20 2016

Cc: steve...@chromium.org x...@chromium.org
Attaching file here too.
cups_printer_error.png
125 KB View Download

Comment 2 by x...@chromium.org, Oct 20 2016

How did you get this error? This assertion error is expected if the printer protocol is not one of ipp/ipps/http/https/socket/lpd/usb. See https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js?rcl=0&l=74.

Comment 3 by dpa...@chromium.org, Oct 20 2016

Encountered that error when running ChromeOS from Linux, using one of the fake printers that show up when you search for printers (see screencast).
printer_error.mp4
369 KB View Download

Comment 4 by x...@chromium.org, Oct 20 2016

Ah I see. It seems the fake printer's protocol is incorrectly initialized here: https://cs.chromium.org/chromium/src/chromeos/printing/fake_printer_discoverer.cc?rcl=0&l=69. I'll work on a fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccb4774cad17a028967e67b49a62a96d1f7af0f

commit 5ccb4774cad17a028967e67b49a62a96d1f7af0f
Author: xdai <xdai@chromium.org>
Date: Tue Oct 25 23:03:03 2016

[CUPS] Fix a typo error of the fake printer's protocol.

The typo caused "Assertion error" when viewing details of a CUPS printer.

BUG= 657672 

Review-Url: https://codereview.chromium.org/2450653003
Cr-Commit-Position: refs/heads/master@{#427522}

[modify] https://crrev.com/5ccb4774cad17a028967e67b49a62a96d1f7af0f/chromeos/printing/fake_printer_discoverer.cc

Labels: Hotlist-MD-Settings-CloudPrint
Owner: x...@chromium.org
Status: Assigned (was: Untriaged)
(Adding Hotlist-MD-Settings-CloudPrint for organization, though I know CUPS is unrelated)

Comment 7 by x...@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
xdai@ Trying to verify this bug. Could you provide verification steps?

Comment 12 by x...@chromium.org, May 19 2017

Re#11: There is repro steps in comment#3. 

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61
Cc: mkarkada@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on M62 (Chrome OS 9807.0.0, 62.0.3176.0 dev build).

Sign in to add a comment