Issue metadata
Sign in to add a comment
|
Fix and reenable browse:news:hackernews system health story |
||||||||||||||||||||
Issue descriptionsystem_health.common_desktop failing on chromium.perf/Win 10 High-DPI Perf (1) Type: build-failure Builders failed on: - Win 10 High-DPI Perf (1): https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf%20%281%29 From the log: C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\image_processing\_bitmap.py:152: UserWarning: Using pure python png decoder, which could be very slow. To speed up, consider installing numpy & cv2 (OpenCV). 'Using pure python png decoder, which could be very slow. To speed up, ' Traceback (most recent call last): File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 86, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function return func(*args, **kwargs) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 310, in RunStory self._current_page.Run(self) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\page\__init__.py", line 109, in Run self.RunPageInteractions(action_runner) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\tools\perf\page_sets\system_health\system_health_story.py", line 112, in RunPageInteractions self._DidLoadDocument(action_runner) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\tools\perf\page_sets\system_health\browsing_stories.py", line 70, in _DidLoadDocument self._ReadNewsItem(action_runner) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\tools\perf\page_sets\system_health\browsing_stories.py", line 75, in _ReadNewsItem action_runner.tab.WaitForDocumentReadyStateToBeComplete() File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 70, in WaitForDocumentReadyStateToBeComplete 'document.readyState == "complete"', timeout) File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 136, in WaitForJavaScriptExpression e.message + '\n' + debug_message) TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue. Console output: INFO:root:Chrome version: 2896 ERROR:root:Error when deleting c:\users\chrome~1.lab\appdata\local\temp\tmpndlhne, will try again at exit. Traceback (most recent call last): File "C:\b\c\b\Win_10_High_DPI_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py", line 275, in CollectAgentTraceData os.remove(self._trace_log) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\users\\chrome~1.lab\\appdata\\local\\temp\\tmpndlhne' [ FAILED ] browse:news:hackernews (172888 ms) It looks like this test has been failing ever since it was added to this bot. Assigning to charliea@, who enabled the test in https://crrev.com/71253911d21dfc93fdeccb6c46e518c2a078a3b9
,
Oct 20 2016
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93d3a4a026d6ad24981f394883b9947edda80bdf commit 93d3a4a026d6ad24981f394883b9947edda80bdf Author: zhenw <zhenw@chromium.org> Date: Sat Nov 12 04:56:13 2016 Disable system_health.common_desktop on Mac and Win10 perf bots TBR=nednguyen@google.com BUG=657665, 653893 , 664661 Review-Url: https://codereview.chromium.org/2498753002 Cr-Commit-Position: refs/heads/master@{#431774} [modify] https://crrev.com/93d3a4a026d6ad24981f394883b9947edda80bdf/tools/perf/benchmarks/system_health.py
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 commit 14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 Author: zhenw <zhenw@chromium.org> Date: Sat Nov 12 16:47:53 2016 Revert of Disable system_health.common_desktop on Mac and Win10 perf bots (patchset #1 id:1 of https://codereview.chromium.org/2498753002/ ) Reason for revert: According to Ned, we should disable the failing story only. Reverting this CL. Will disable the story on Monday. Original issue's description: > Disable system_health.common_desktop on Mac and Win10 perf bots > > TBR=nednguyen@google.com > BUG=657665, 653893 , 664661 > > Committed: https://crrev.com/93d3a4a026d6ad24981f394883b9947edda80bdf > Cr-Commit-Position: refs/heads/master@{#431774} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657665, 653893 , 664661 Review-Url: https://codereview.chromium.org/2498693003 Cr-Commit-Position: refs/heads/master@{#431789} [modify] https://crrev.com/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1/tools/perf/benchmarks/system_health.py
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2348f7913c2985d0d2967910cfb450330778b806 commit 2348f7913c2985d0d2967910cfb450330778b806 Author: zhenw <zhenw@chromium.org> Date: Mon Nov 14 19:00:25 2016 Disable browse:news:hackernews on Win perf bot BUG=657665 Review-Url: https://codereview.chromium.org/2499983002 Cr-Commit-Position: refs/heads/master@{#431880} [modify] https://crrev.com/2348f7913c2985d0d2967910cfb450330778b806/tools/perf/page_sets/system_health/browsing_stories.py
,
Nov 15 2016
,
Nov 15 2016
,
Nov 28 2016
Mac 10.10 and 10.11 seem to be failing with similar output: https://chromium-swarm.appspot.com/task?id=32b1802e6d8f7710&refresh=10&show_raw=1 and https://chromium-swarm.appspot.com/task?id=32b186e9ce295d10&refresh=10&show_raw=1. I'm going to disable it on those platforms.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6735fcba31571d3b55e3f8e99bf36f00ede9695d commit 6735fcba31571d3b55e3f8e99bf36f00ede9695d Author: sammc <sammc@chromium.org> Date: Mon Nov 28 05:34:45 2016 Disable browse:news:hackernews on Mac 10.10 and 10.11. BUG=657665 TBR=eakuefner@chromium.org Review-Url: https://codereview.chromium.org/2531993002 Cr-Commit-Position: refs/heads/master@{#434608} [modify] https://crrev.com/6735fcba31571d3b55e3f8e99bf36f00ede9695d/tools/perf/page_sets/system_health/browsing_stories.py
,
Dec 7 2016
Issue 664541 has been merged into this issue.
,
Dec 21 2016
,
Dec 21 2016
Charlie, had you had any look figuring out the problem with this story?
,
Dec 28 2016
I haven't had a chance to look into it, unfortunately. Can't say much other than that this is on my backlog.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/187cdc9728275a1d5120738442cc10d6566538d3 commit 187cdc9728275a1d5120738442cc10d6566538d3 Author: fmeawad <fmeawad@chromium.org> Date: Fri Mar 10 01:27:33 2017 Disable browse:news:hackernews on all mac Disabling it for ElCapitan does not seem to work, disabling it for all mac platforms instead as the orignal comment suggest. Filed a catapult isuse at https://github.com/catapult-project/catapult/issues/3359 BUG=657665 Review-Url: https://codereview.chromium.org/2744513004 Cr-Commit-Position: refs/heads/master@{#455948} [modify] https://crrev.com/187cdc9728275a1d5120738442cc10d6566538d3/tools/perf/page_sets/system_health/browsing_stories.py
,
Mar 23 2017
The timeout in WaitForDocumentReadyStateToBeComplete happens very often in different stories. perezju@, nednguyen@, any chance we can get a screenshot or webpage state uploaded on such timeout? That would help with debugging since engineers don't have local "Win 10 High-DPI Perf" machines.
,
Mar 23 2017
To #15: we should already have screenshot upon failure: https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/page/shared_page_state.py#L136
,
Mar 23 2017
Hmm, they should have the screenshot, but for some reason some of these failures don't have it. A couple of examples where the TimeoutException is there, but I can't find the screenshot in the logs: mac-pro-10.11 memory - 743 - browse:news:cnn - 2 https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Pro_10.11_Perf%2F743%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_on_ATI_GPU_on_Mac_on_Mac-10.11%2F0%2Fstdout mac-retina memory - 454 - browse:news:cnn - 3 https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Retina_Perf%2F454%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_on_Intel_GPU_on_Mac_on_Mac-10.11%2F0%2Fstdout
,
Jun 22 2017
I ran this locally and it seemed to work fine on Mac. I launched a perf try job at https://codereview.chromium.org/2956533002/ and am going to keep an eye on how it does.
,
Jun 24 2017
The NextAction date has arrived: 2017-06-24
,
Jun 26 2017
Looks like the try job still failed on some mac bots :(
,
Aug 6
Marking this as "available" to reflect the fact that I haven't made any progress on this in >1y.
,
Jan 16
,
Jan 16
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by martiniss@chromium.org
, Oct 20 2016