Consider backing Blink's TransformationMatrix.h with Skia's SkMatrix44.h |
|||
Issue descriptiongfx's Transform[1] is a thin wrapper around a SkMatrix44[2]. Could we do the same for Blink's TransformationMatrix[3]? Tien-Ren recently asked why we also have TransformationMatrix in Blink and I didn't have a good answer. We recently added more SIMD optimizations[4] to TransformationMatrix so I assume this code is hot on some profiles. Does it make sense to move these optimizations to SkMatrix44 and back TransformationMatrix by SkMatrix44 so all of Chrome shares one super fast implementation? [1] https://cs.chromium.org/chromium/src/ui/gfx/transform.h [2] https://cs.chromium.org/chromium/src/third_party/skia/include/core/SkMatrix44.h [3] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h [4] https://chromium.googlesource.com/chromium/src/+/07dceb76cfef62e581b2f9bb9c25b41746af07fc
,
Oct 20 2016
Chrome (today) has decided to configure SkMatrix44 as floats (compile-time option). blink's TransformationMatrix is doubles.
,
Oct 20 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
I don't think we will go ahead with this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by esprehn@chromium.org
, Oct 19 2016