New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657647 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-26
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

Disabled md-select is too light

Project Member Reported by michae...@chromium.org, Oct 19 2016

Issue description

The text color of a disabled md-select is effectively rgb(208, 208, 208), which is the same as saying 18% opaque. This is a polish bug but also wouldn't meet contrast requirements.

The md-select <select> is --secondary-text-color and also opacity: 0.33. Should only one of those styles be applied instead of compounding them?
 

Comment 1 by dpa...@chromium.org, Oct 19 2016

The opacity .33 is necessary to make the down arrow also lighter IIRC, but I'll double check.

Comment 2 by dpa...@chromium.org, Oct 20 2016

@michaelpg: I think that I tried to replicate exactly the disabled look of the paper-dropdown-menu at https://codereview.chromium.org/2406993002. See attachments comparing the two (they look the same level of gray to me).

Are you saying that md-select does not match paper-dropdown-menu, or that regardless if it matches or not, it should be tweaked?
md_select_disabled.png
895 bytes View Download
paper_disabled.png
1.8 KB View Download

Comment 3 by dpa...@chromium.org, Oct 21 2016

Labels: Needs-Feedback

Comment 4 by dpa...@chromium.org, Oct 31 2016

Cc: michae...@chromium.org
Ping @michaelpg, see comment #2.
Labels: -Needs-Feedback
Regardless of whether it matches, I suspect it fails our contrast ratio a11y requirements.

I also recall doing a comparison at the time and finding the md-select to be lighter than the old settings-dropdown-menu. I can't do that now without going back to an earlier build, but dropping in a <paper-dropdown-menu> in inspector shows it to be darker than the md-select (may or may not be a valid test).
select.png
13.7 KB View Download
Cc: hcarmona@chromium.org bettes@chromium.org dbeam@chromium.org
>Regardless of whether it matches, I suspect it fails our contrast ratio a11y requirements.

Can we get UX or a11y opinion on this before changing it?
Cc: lpalmaro@chromium.org
Labels: Needs-Feedback
lpalmaro: Do we need to worry about contrast ratio for disabled controls?

Some context found in issue 603620#1:

> All text on all pages must meet an absolute min contrast level of 4.5:1

But WCAG 2.0 actually says that "incidental" text ("part of an inactive user interface component") has no contrast requirement. Still, the effective contrast here if the values in my original description are correct is 1.54:1 which is really low.

http://webaim.org/resources/contrastchecker/?fcolor=d0d0d0&bcolor=ffffff
Cc: dpa...@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)

Comment 9 by chaok@google.com, Dec 13 2016

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!

Comment 10 by chaok@google.com, Jan 26 2017

Labels: Hotlist-MD-Settings-PageA11y
NextAction: 2017-01-26
Blocking: 671375
Status: Available (was: Untriaged)
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff04fe72fb9f627f2aae234a7893f88f2debbf71

commit ff04fe72fb9f627f2aae234a7893f88f2debbf71
Author: scottchen <scottchen@chromium.org>
Date: Thu Mar 16 19:43:45 2017

MD Settings: change disabled select visuals.

The visual we had for disabled md-select was too light for a11y standards; this CL gives it the same visuals as other disabled elements in md-settings.

BUG= 657647 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753983002
Cr-Commit-Position: refs/heads/master@{#457522}

[modify] https://crrev.com/ff04fe72fb9f627f2aae234a7893f88f2debbf71/ui/webui/resources/html/md_select_css.html

Status: Fixed (was: Started)

Sign in to add a comment