MD Settings: Critical features missing from Cookies exception management. |
|||||||||||||||||
Issue descriptionAs a heavy user of the cookies exception settings, I've discovered 4 critical features (some more critical than others) missing from the new MD Settings page. 1) No placeholder text, instructing on the expected regex pattern, see no_placeholder_text.png. 2) No visual validation hint when the currently entered pattern is invalid. Notice that the "add" button in the dialog is displayed, but no "red" warning is shown, see no_validation_hints.png 3) After inserting a matching pattern for the exception, for example https://[*.]google.com, the UI is only showing https://google.com. This makes it impossible to know whether this pattern will match all subdomains as intended, see pattern_never_shown.png. There is no way to resurface the "[*.]" part of the exception to the user again. 4) No ability to edit a cookie exception. If a user makes a typo, or needs to adjust any exception for whatever reason, deleting the exception and adding it from scratch is necessary, see no_editing.png. Individual cookie management is a power-user feature, so trying to "simplify" it by hiding information or removing functionality is not an appropriate objective IMO.
,
Oct 20 2016
For issue (2) I think a text note about what the issue is would be more helpful than the red background. I think the red and the disabled button accomplish the same result - something is wrong. Neither give a hint about what the user should do to address the wrongness.
,
Oct 20 2016
I am not suggesting a red background on the new UI. Instead I expect the validation error to be triggering a warning message, similar to other places (see search engines screenshot). I agree though that the text could be more helpful than "not valid".
,
Oct 20 2016
Hey Demetrios, Thanks for the thorough run-through. I believe most of these issues are implementation, not design, specific. Assigning to Dave as he's working on the broader set of Site Settings changes. 1) No placeholder text, instructing on the expected regex pattern, see no_placeholder_text.png. This dialog isn't to spec. Once it is, I have no problem adding in the hint text that we see in today's settings. This shouldn't need mocks. 2) No visual validation hint when the currently entered pattern is invalid. Notice that the "add" button in the dialog is displayed, but no "red" warning is shown, see no_validation_hints.png Open to suggestions on invalid strings, but a good starting point is just using the strings we have today. The validation UI should mimic what we do in Search engines (and everywhere else) as alluded to in comment 3. Again, no mocks expected here. 3) After inserting a matching pattern for the exception, for example https://[*.]google.com, the UI is only showing https://google.com. This makes it impossible to know whether this pattern will match all subdomains as intended, see pattern_never_shown.png. There is no way to resurface the "[*.]" part of the exception to the user again. I'm not quite understanding what is to be expected here. If showing the "[*.]"in the list is expected, I believe this is an implementation issue, not a design one. Assign back to me if otherwise. 4) No ability to edit a cookie exception. If a user makes a typo, or needs to adjust any exception for whatever reason, deleting the exception and adding it from scratch is necessary, see no_editing.png. There is more friction to editing a site exception in the new UI, but I'm not convinced it warrants adding a 4th item to the overflow menu. If there's strong feelings towards the need to support this, then adding 'Edit' as the third item in the menu is the most viable way forward. 'Edit' prompts a dialog titled 'Edit [url]"
,
Oct 27 2016
,
Jan 27 2017
Should this be a blocking bug for our launch issue 671375 ? Not being able to edit cookies is a major regression compared to previous UI. Can we rethink this, perhaps spawn the "Edit cookie" functionality to a separate bug and block our launch on it? Giving a simple example on how without editing cookies some user workflows are impossible (see screencast too). 1) User turns off cookies for all sites. 2) User visits a site of interest (let's say bankofamerica.com) and wants to login. 3) User enables cookies just for that site. The cookie exception being added by default is very specific, https://[*.]www.bankofamerica.com:443. 4) User wants to make it more generic so that it works on all sub-sites of bankofamerica, so tries to edit to https://[*.]bankofamerica.com This is unfortunately not possible anymore with the new MD Settings page. Privacy is a big part of Chrome. Being able to surf the web with all cookies disabled, and being able to issue specific exceptions for websites of interest is critical for users who have privacy high in their priorities.
,
Jan 28 2017
Copying the hostname in order to paste it is buggy on its own, see video where I am trying to Copy but it is disabled, unless I very carefully drag my mouse (as to not select accidentally hidden but selectable text). Also adding a new exception and removing the old one, is more cumbersome than just editing the existing exception.
,
Jan 28 2017
i meant copying from the omnibox
,
Jan 28 2017
Copying from the omnibox is tedious for two reasons 1) I need to type https://[*.] myself by actually typing it. 2) I need to filter out things from the omnibox URL myself (see screenshot example). Now imagine that I have about a 100 such exceptions in my real world profile.
,
Jan 31 2017
,
Jan 31 2017
tbuckley@ and I talked about this and he thinks it's OK to add another click or two, but we should add an "Edit" action to the ... menu for each exception. dpapad@: sound good to you? also note: I think we should add 1 more option to the native bubble that shows up for content exceptions when on a subdomain that leaves protocol (and maybe port) the same but chops off subdomains, i.e. (o) Allow cookies from *.google.com ( ) Allow cookies from accounts.google.com ( ) Keep blocking cookies As functionally stripping subdomain (trusting a whole domain) is probably common. Note: if it's a sub.sub.domain.com I'd argue we should only show domain.com.
,
Jan 31 2017
"edit" option in action menu SGTM. Smarter native bubble to add an exception sounds great.
,
Feb 7 2017
,
Feb 16 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a870cddc366197ab52a0c8340e2941e3bacabcd commit 9a870cddc366197ab52a0c8340e2941e3bacabcd Author: dpapad <dpapad@chromium.org> Date: Fri Feb 17 03:30:17 2017 MD Settings: Unify multiple copies of the "edit" string to a single IDS_SETTINGS_EDIT. BUG= 657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2697223004 Cr-Commit-Position: refs/heads/master@{#451202} [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/app/settings_strings.grdp [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html [modify] https://crrev.com/9a870cddc366197ab52a0c8340e2941e3bacabcd/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188b7bdc8292a7b740f7caa3d26bfd89aac5a924 commit 188b7bdc8292a7b740f7caa3d26bfd89aac5a924 Author: dpapad <dpapad@chromium.org> Date: Fri Feb 24 01:49:23 2017 MD Settings: Allow editing a cookie site exception. BUG= 657639 , 695578 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2699013002 Cr-Commit-Position: refs/heads/master@{#452712} [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/app/settings_strings.grdp [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/add_site_dialog.html [add] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html [add] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75 commit a92b519592dabba45a0e7f0bd2b52f9e33a7ae75 Author: dpapad <dpapad@chromium.org> Date: Tue Feb 28 05:05:28 2017 MD Settings: Add placeholder text when adding/editing a content exception. BUG= 657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2715243009 Cr-Commit-Position: refs/heads/master@{#453506} [modify] https://crrev.com/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75/chrome/app/settings_strings.grdp [modify] https://crrev.com/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html [modify] https://crrev.com/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5046f55745940bd248cb51c38d45e7ff39cc75f3 commit 5046f55745940bd248cb51c38d45e7ff39cc75f3 Author: dpapad <dpapad@chromium.org> Date: Thu Mar 30 20:52:22 2017 MD Settings: Display error messages in "add" and "edit" exception dialogs. BUG= 657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2783513002 Cr-Commit-Position: refs/heads/master@{#460868} [modify] https://crrev.com/5046f55745940bd248cb51c38d45e7ff39cc75f3/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/5046f55745940bd248cb51c38d45e7ff39cc75f3/chrome/browser/resources/settings/site_settings/add_site_dialog.js [modify] https://crrev.com/5046f55745940bd248cb51c38d45e7ff39cc75f3/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html [modify] https://crrev.com/5046f55745940bd248cb51c38d45e7ff39cc75f3/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js [modify] https://crrev.com/5046f55745940bd248cb51c38d45e7ff39cc75f3/chrome/test/data/webui/settings/site_list_tests.js
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a commit 2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a Author: dpapad <dpapad@chromium.org> Date: Thu Mar 30 21:08:47 2017 MD Settings: Change some instances of "Not valid" to "Not a valid web address". BUG= 657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787053002 Cr-Commit-Position: refs/heads/master@{#460875} [modify] https://crrev.com/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a/chrome/app/settings_strings.grdp [modify] https://crrev.com/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html [modify] https://crrev.com/2b6c8430a8b66ce84ec2b4f6196c5332f407ea2a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Mar 30 2017
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by dpa...@chromium.org
, Oct 19 201673.9 KB
73.9 KB View Download