New issue
Advanced search Search tips

Issue 657620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unify kRenderQuantumFrames and ProcessingSizeInFrames

Project Member Reported by rtoy@chromium.org, Oct 19 2016

Issue description

WebAudio code uses both kRenderQuantumFrames and ProcessingSizeInFrames to denote the rendering quantum size of 128 frames.

Unify this.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7198aeec6e82994ef5060872852997fccd74410

commit b7198aeec6e82994ef5060872852997fccd74410
Author: rtoy <rtoy@chromium.org>
Date: Tue Nov 01 00:09:07 2016

Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG= 657620 
TESTS=none; an internal change not visible.

Review-Url: https://codereview.chromium.org/2440583002
Cr-Commit-Position: refs/heads/master@{#428875}

[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Comment 3 by rtoy@chromium.org, Nov 8 2016

Status: Fixed (was: Assigned)

Sign in to add a comment