MacViews textfields: right click should select the word under the cursor if nothing is selected. |
|||||
Issue descriptionVersion: 56.0.2895.0 OS: 10.11 What steps will reproduce the problem? (1) Type some text into a MacViews text field. (2) Right click on a word. What is the expected output? The word should become selected. What do you see instead? Nothing is selected.
,
Oct 19 2016
,
Oct 20 2016
karandeepb@, please take a look at this :)
,
Dec 19 2016
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9f75eab14f8845b5f23d0d50286191454f9f90d commit e9f75eab14f8845b5f23d0d50286191454f9f90d Author: karandeepb <karandeepb@chromium.org> Date: Thu Dec 22 09:46:32 2016 MacViews: Select word under cursor on right click. This CL modifies SelectionController::OnMousePressed to ensure right clicking outside the current selection, selects the word under the cursor on Mac. A new constant PlatformStyle::kSelectWordOnRightClick is introduced to facilitate this. BUG= 657556 TEST= On Mac, enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Ensure the word under the cursor is selected on a right click outside the current selection. Review-Url: https://codereview.chromium.org/2580293003 Cr-Commit-Position: refs/heads/master@{#440373} [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/controls/textfield/textfield_unittest.cc [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/selection_controller.cc [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/selection_controller.h [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/style/platform_style.cc [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/style/platform_style.h [modify] https://crrev.com/e9f75eab14f8845b5f23d0d50286191454f9f90d/ui/views/style/platform_style_mac.mm
,
Dec 22 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sdy@chromium.org
, Oct 19 2016