New issue
Advanced search Search tips

Issue 657541 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove DataReductionProxy.MissingViaHeader.Bytes.* histograms and related code

Project Member Reported by tbansal@chromium.org, Oct 19 2016

Issue description

DataReductionProxyRemoveMissingViaHeaderOtherBypass field trial has been turned down. So, dData is no longer recorded in DataReductionProxy.MissingViaHeader.Bytes.* histograms.

We should mark those histograms as obsolete, and remove the related code.
 

Comment 1 by bengr@chromium.org, Oct 28 2016

Status: Available (was: Untriaged)
Labels: CleanUp

Comment 3 by bengr@chromium.org, Nov 8 2017

Refreshed during triage.
Refreshed during triage.
Refreshed during triage.
Owner: sclit...@chromium.org
Status: Assigned (was: Available)
I'll do this at some point.
Owner: robertogden@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07992c164a4fc56bcb699cd630ba119ddf943bb4

commit 07992c164a4fc56bcb699cd630ba119ddf943bb4
Author: Robert Ogden <robertogden@chromium.org>
Date: Tue Apr 17 16:52:43 2018

Remove DataReductionProxy.MissingViaHeader.Bytes.* histograms

Removes the histograms and related code, as well as what little helper
functions were added when these histograms were added.

Bug:  657541 
Change-Id: I4bebf6d2b70fad9c0eb6b40edea9507f61e9bae3
Reviewed-on: https://chromium-review.googlesource.com/1014344
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551364}
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
[modify] https://crrev.com/07992c164a4fc56bcb699cd630ba119ddf943bb4/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment