New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 657520



Sign in to add a comment

Malware download text color should match icon

Project Member Reported by emilyschechter@chromium.org, Oct 19 2016

Issue description

Malware recovery download page currently shows orange warning text.

This text color should match the red icon.

We should decide on https://bugs.chromium.org/p/chromium/issues/detail?id=657520 first, then update the text color to match.
 

Comment 1 by bettes@chromium.org, Oct 19 2016

Text should be #C53929
Cc: emilyschechter@chromium.org
Labels: M-56
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
dbeam@, could you help with this one since you're most familiar with the md download page?  Probably just a one line change, given bettes@'s comment. 
AjDXm2b2xvh.png
153 KB View Download

Comment 3 by dbeam@chromium.org, Oct 28 2016

so, in this case (with an even lighter color?)
2016-10-28-143618_962x420_scrot.png
36.4 KB View Download
Thanks for bring this special case up, dbeam@! 
+bettes@, the screenshot in comment 3 is the default warning, where either user turns off safe browsing or safe browsing service is not reachable. Any suggestion on what color this text should be (when the icon is yellow)? 
Blockedon: 657520
Ah, based on https://bugs.chromium.org/p/chromium/issues/detail?id=657520#c4
"The red triangle should replace any "circle with dash" and yellow triangles. " 

dbeam@, could you help replacing the icon as well? ( I honestly don't know how to replace icons on download page. Or could you show me how?)
I think I figured it out how to replace icons. dbeam@, I'll send you a CL for review shortly. 

Comment 7 by dbeam@chromium.org, Nov 1 2016

Cc: -jialiul@chromium.org dbeam@chromium.org
Owner: jialiul@chromium.org
And since we are replacing "circle with dash" with red triangle, the text color should be probably be #DD4330 too. 
Yep, text color should match
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6882854516c760d962aea5924f52fd3c68184c

commit 4a6882854516c760d962aea5924f52fd3c68184c
Author: jialiul <jialiul@chromium.org>
Date: Wed Nov 02 17:35:36 2016

Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG= 657520 ,  657523 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2465723004
Cr-Commit-Position: refs/heads/master@{#429324}

[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_100_percent/legacy/safebrowsing_warning.png
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.js
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/ui/views/download/download_item_view.cc

Components: UI>Browser>SafeBrowsing UI>Browser>Downloads
Status: Fixed (was: Assigned)

Sign in to add a comment