Malware download text color should match icon |
|||||
Issue descriptionMalware recovery download page currently shows orange warning text. This text color should match the red icon. We should decide on https://bugs.chromium.org/p/chromium/issues/detail?id=657520 first, then update the text color to match.
,
Oct 28 2016
dbeam@, could you help with this one since you're most familiar with the md download page? Probably just a one line change, given bettes@'s comment.
,
Oct 28 2016
so, in this case (with an even lighter color?)
,
Oct 28 2016
Thanks for bring this special case up, dbeam@! +bettes@, the screenshot in comment 3 is the default warning, where either user turns off safe browsing or safe browsing service is not reachable. Any suggestion on what color this text should be (when the icon is yellow)?
,
Oct 31 2016
Ah, based on https://bugs.chromium.org/p/chromium/issues/detail?id=657520#c4 "The red triangle should replace any "circle with dash" and yellow triangles. " dbeam@, could you help replacing the icon as well? ( I honestly don't know how to replace icons on download page. Or could you show me how?)
,
Oct 31 2016
I think I figured it out how to replace icons. dbeam@, I'll send you a CL for review shortly.
,
Nov 1 2016
,
Nov 1 2016
And since we are replacing "circle with dash" with red triangle, the text color should be probably be #DD4330 too.
,
Nov 1 2016
Yep, text color should match
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a6882854516c760d962aea5924f52fd3c68184c commit 4a6882854516c760d962aea5924f52fd3c68184c Author: jialiul <jialiul@chromium.org> Date: Wed Nov 02 17:35:36 2016 Make download warning icon and text more consistent (1) replace previous dangerous warning icons (circle with dash and yellow triangle) to red triangles (2) make the color of this icon consistent on download shelf and download page (rgb color DD4330) (3) make the warning text color consistent with icon color BUG= 657520 , 657523 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2465723004 Cr-Commit-Position: refs/heads/master@{#429324} [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_100_percent/legacy/safebrowsing_warning.png [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/ui/views/download/download_item_view.cc
,
Nov 2 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bettes@chromium.org
, Oct 19 2016