New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 657523



Sign in to add a comment

Malware download shelf & download recovery icons should match

Project Member Reported by emilyschechter@chromium.org, Oct 19 2016

Issue description

Icons should match between download shelf and downloads recovery page. Right now we use two different (-) icons.

I would prefer that we use the red danger triangle icon for both, to match the omnibox icons.
 

Comment 1 by bettes@chromium.org, Oct 19 2016

SGTM. Do you need assets for the download shelf and downloads page? Please assign to myself or max for traige.

A plus would be to attach the existing assets being used in both areas. 
Owner: bettes@chromium.org
Thanks, bettes@! Assign it to you for triaging. 
The warning icon on download shelf is a legacy icon which resides at https://cs.chromium.org/chromium/src/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png

And the warning icon on chrome://downloads page is a svg icon https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.html?rcl=0&l=40

Can we just re-use the triangle asset from the omnibox for this? Or does it have to be re-sized or something?

Comment 4 by bettes@chromium.org, Oct 29 2016

Cc: -jialiul@chromium.org
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
The red triangle should replace any "circle with dash" and yellow triangles. 

Attached is a 48x48 png asset and a svg for the danger triangle. Color svg #DD4330 if used. 


warning.png
658 bytes View Download
warning.svg
549 bytes Download
Cc: dbeam@chromium.org
+dbeam@, since it is related to https://bugs.chromium.org/p/chromium/issues/detail?id=657523

Blocking: 657523
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6882854516c760d962aea5924f52fd3c68184c

commit 4a6882854516c760d962aea5924f52fd3c68184c
Author: jialiul <jialiul@chromium.org>
Date: Wed Nov 02 17:35:36 2016

Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG= 657520 ,  657523 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2465723004
Cr-Commit-Position: refs/heads/master@{#429324}

[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_100_percent/legacy/safebrowsing_warning.png
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.js
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/ui/views/download/download_item_view.cc

Components: UI>Browser>SafeBrowsing UI>Browser>Downloads
Status: Fixed (was: Assigned)

Sign in to add a comment