Malware download shelf & download recovery icons should match |
||||||
Issue descriptionIcons should match between download shelf and downloads recovery page. Right now we use two different (-) icons. I would prefer that we use the red danger triangle icon for both, to match the omnibox icons.
,
Oct 20 2016
Thanks, bettes@! Assign it to you for triaging. The warning icon on download shelf is a legacy icon which resides at https://cs.chromium.org/chromium/src/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png And the warning icon on chrome://downloads page is a svg icon https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.html?rcl=0&l=40
,
Oct 20 2016
Can we just re-use the triangle asset from the omnibox for this? Or does it have to be re-sized or something?
,
Oct 29 2016
The red triangle should replace any "circle with dash" and yellow triangles. Attached is a 48x48 png asset and a svg for the danger triangle. Color svg #DD4330 if used.
,
Oct 31 2016
+dbeam@, since it is related to https://bugs.chromium.org/p/chromium/issues/detail?id=657523
,
Oct 31 2016
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a6882854516c760d962aea5924f52fd3c68184c commit 4a6882854516c760d962aea5924f52fd3c68184c Author: jialiul <jialiul@chromium.org> Date: Wed Nov 02 17:35:36 2016 Make download warning icon and text more consistent (1) replace previous dangerous warning icons (circle with dash and yellow triangle) to red triangles (2) make the color of this icon consistent on download shelf and download page (rgb color DD4330) (3) make the warning text color consistent with icon color BUG= 657520 , 657523 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2465723004 Cr-Commit-Position: refs/heads/master@{#429324} [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_100_percent/legacy/safebrowsing_warning.png [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c/chrome/browser/ui/views/download/download_item_view.cc
,
Nov 2 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bettes@chromium.org
, Oct 19 2016