Cras_test_client is not terminating while running audio test cases.
Reported by
raghuvee...@intel.com,
Oct 19 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36 Platform: 8805.0.0-16.09.15 Steps to reproduce the problem: 1) play sound from youtube first, then run 2) "cras_test_client --loopback_file /tmp/loopback.wav --duration_seconds 20" 3) after exit, stop youtube, run the following cmd to verify the captured file: 4) "cras_test_client --playback_file /tmp/loopback.wav What is the expected behavior? The cras_test_client should run the loopback successfully. What went wrong? It looks like the duration_seconds option is broken. Did this work before? Yes Chrome version: 53.0.2785.143 Channel: dev OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0
,
Oct 19 2016
,
Oct 20 2016
,
Nov 29 2016
Fixing it now. Sorry for late response.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/799c76d611d945f314561965fb358eee2943b803 commit 799c76d611d945f314561965fb358eee2943b803 Author: Hsin-Yu Chao <hychao@chromium.org> Date: Tue Nov 29 07:48:19 2016 CRAS: loopbacl_iodev - Fix get_buffer callback Get buffer should not return frames more than requrested. BUG= chromium:657510 TEST=cras_test_client --loopback_file /tmp/loopback Change-Id: Ie789cbff30ede279e63e67f5822c36ab8a8c4dc7 Reviewed-on: https://chromium-review.googlesource.com/414750 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> [modify] https://crrev.com/799c76d611d945f314561965fb358eee2943b803/cras/src/server/cras_loopback_iodev.c
,
Nov 30 2016
,
Nov 30 2016
We have cherry-picked and verified the fix .
,
Nov 30 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/47281c0f6e57b464ba6ca6c4bcb38e93c282561a commit 47281c0f6e57b464ba6ca6c4bcb38e93c282561a Author: Hsin-Yu Chao <hychao@chromium.org> Date: Tue Nov 29 07:48:19 2016 CRAS: loopbacl_iodev - Fix get_buffer callback Get buffer should not return frames more than requrested. BUG= chromium:657510 TEST=cras_test_client --loopback_file /tmp/loopback Change-Id: Ie789cbff30ede279e63e67f5822c36ab8a8c4dc7 Reviewed-on: https://chromium-review.googlesource.com/414750 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> (cherry picked from commit 799c76d611d945f314561965fb358eee2943b803) Reviewed-on: https://chromium-review.googlesource.com/415848 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/47281c0f6e57b464ba6ca6c4bcb38e93c282561a/cras/src/server/cras_loopback_iodev.c
,
Dec 1 2016
,
Dec 16 2016
Verified on build 9000.28.0
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/ea116ee6d2f4b2c11e973c5e56912b63a4549d07 commit ea116ee6d2f4b2c11e973c5e56912b63a4549d07 Author: Hsin-Yu Chao <hychao@chromium.org> Date: Tue Nov 29 07:48:19 2016 CRAS: loopbacl_iodev - Fix get_buffer callback Get buffer should not return frames more than requrested. BUG= chromium:657510 TEST=cras_test_client --loopback_file /tmp/loopback Change-Id: Ie789cbff30ede279e63e67f5822c36ab8a8c4dc7 Reviewed-on: https://chromium-review.googlesource.com/414750 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/425530 Reviewed-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/ea116ee6d2f4b2c11e973c5e56912b63a4549d07/cras/src/server/cras_loopback_iodev.c |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dgreid@chromium.org
, Oct 19 2016