Should cover: dismissing status cards, removing categories, all dismissed state, etc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb75020ad83b3133a4e08cbec2b01f0dff44f378 commit bb75020ad83b3133a4e08cbec2b01f0dff44f378 Author: dgn <dgn@chromium.org> Date: Thu Oct 20 12:39:45 2016 [NTP Client] Put dismissing sections behind a flag Dismissing status cards (and sections) now requires the NTPSuggestionsSectionDismissal feature to be enabled. Dismissing the Sign In promo is still possible. BUG= 657494 Review-Url: https://chromiumcodereview.appspot.com/2440673002 Cr-Commit-Position: refs/heads/master@{#426457} [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/components/ntp_snippets/features.cc [modify] https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378/components/ntp_snippets/features.h
Requesting merge on M55. The merge CL is https://chromiumcodereview.appspot.com/2431373003/ (just disables the feature instead of doing all the modifications to add a new flag)
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Waiting for it to land in Canary to merge.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b031ce46271b15c5f0ac2ea52f00d2c19bc715e commit 4b031ce46271b15c5f0ac2ea52f00d2c19bc715e Author: dgn <dgn@chromium.org> Date: Mon Oct 24 10:28:03 2016 [NTP Client][M55] Make status cards non dismissable NOPRESUBMIT=true NOTRY=true BUG= 657494 Review-Url: https://codereview.chromium.org/2431373003 Cr-Commit-Position: refs/branch-heads/2883@{#240} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4b031ce46271b15c5f0ac2ea52f00d2c19bc715e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/4b031ce46271b15c5f0ac2ea52f00d2c19bc715e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java [modify] https://crrev.com/4b031ce46271b15c5f0ac2ea52f00d2c19bc715e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by dgn@chromium.org
, Oct 20 2016Labels: -zine-client-ux zine-client-ux-v1