New issue
Advanced search Search tips

Issue 657473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Direct-leak in initYCbCrConversion

Project Member Reported by ClusterFuzz, Oct 19 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5922878916919296

Fuzzer: libfuzzer_radamsa_pdf_codec_tiff_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  initYCbCrConversion
  PickSeparateCase
  TIFFRGBAImageBegin
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=422880:422991

Minimized Testcase (1.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97zOcSd7i8ZHfS1FEsGK0irX0hLopbaxXu2bFA-HoPbQx1XNuDaWgH2T4giGa8MRna1ELg-Bglc1L8n05FA3p-xtq0rYsFH3bEKOVUdfB8GI1M8HKnh5mw4jydVZB5FYhgjT81suCIiTuzKeJZKPq6T238SaQ?testcase_id=5922878916919296

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Dan Sinclair @ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !
Blocking: 62400
Components: Internals>Plugins>PDF
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by npm@chromium.org, Dec 1 2016

Cc: npm@chromium.org
I see how to fix this, but the bug needs to be fixed in libtiff code, and they have not fixed this. How do we proceed in this case, Dan?

Comment 5 by npm@chromium.org, Dec 1 2016

Cc: -npm@chromium.org dsinclair@chromium.org
Owner: npm@chromium.org
Status: Started (was: Assigned)

Comment 6 by npm@chromium.org, Dec 5 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2545723004/

Also submitted a bug on libtiff to see if they accept the patch. 
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8592ce0a3fd37846a92824d40c714181e71ea557

commit 8592ce0a3fd37846a92824d40c714181e71ea557
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Dec 05 18:10:31 2016

Roll src/third_party/pdfium/ f6ee82073..7341149c6 (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/f6ee820732b8..7341149c634e

$ git log f6ee82073..7341149c6 --date=short --no-merges --format='%ad %ae %s'
2016-12-05 npm Fix a leak when TIFFRGBAImageBegin fails

BUG= 657473 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2549183002
Cr-Commit-Position: refs/heads/master@{#436348}

[modify] https://crrev.com/8592ce0a3fd37846a92824d40c714181e71ea557/DEPS

Project Member

Comment 8 by ClusterFuzz, Dec 6 2016

ClusterFuzz has detected this issue as fixed in range 436300:436366.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5922878916919296

Fuzzer: libfuzzer_radamsa_pdf_codec_tiff_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  initYCbCrConversion
  PickSeparateCase
  TIFFRGBAImageBegin
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=422880:422991
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=436300:436366

Minimized Testcase (1.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97zOcSd7i8ZHfS1FEsGK0irX0hLopbaxXu2bFA-HoPbQx1XNuDaWgH2T4giGa8MRna1ELg-Bglc1L8n05FA3p-xtq0rYsFH3bEKOVUdfB8GI1M8HKnh5mw4jydVZB5FYhgjT81suCIiTuzKeJZKPq6T238SaQ?testcase_id=5922878916919296

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Dec 6 2016

ClusterFuzz has detected this issue as fixed in range 436300:436366.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5922878916919296

Fuzzer: libfuzzer_radamsa_pdf_codec_tiff_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  initYCbCrConversion
  PickSeparateCase
  TIFFRGBAImageBegin
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=422880:422991
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=436300:436366

Minimized Testcase (1.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97zOcSd7i8ZHfS1FEsGK0irX0hLopbaxXu2bFA-HoPbQx1XNuDaWgH2T4giGa8MRna1ELg-Bglc1L8n05FA3p-xtq0rYsFH3bEKOVUdfB8GI1M8HKnh5mw4jydVZB5FYhgjT81suCIiTuzKeJZKPq6T238SaQ?testcase_id=5922878916919296

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a632b7538653defc7505abf3eefc1087fd3b957

commit 7a632b7538653defc7505abf3eefc1087fd3b957
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Tue Jan 03 18:01:34 2017

Roll src/third_party/pdfium/ fa05e97fc..05f541279 (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/fa05e97fc4d7..05f541279ec0

$ git log fa05e97fc..05f541279 --date=short --no-merges --format='%ad %ae %s'
2017-01-03 npm Libtiff update with upstream

BUG= 657473 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2606383004
Cr-Commit-Position: refs/heads/master@{#441152}

[modify] https://crrev.com/7a632b7538653defc7505abf3eefc1087fd3b957/DEPS

Sign in to add a comment