New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CronetUrlRequestTest#testFailures flake

Project Member Reported by mge...@chromium.org, Oct 19 2016

Issue description

Different from the one before. This one affects the native implementation.

C  178.503s Main  [FAIL] org.chromium.net.CronetUrlRequestTest#testFailures:
C  178.503s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  178.503s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137)
C  178.503s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  178.503s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  178.503s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  178.503s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  178.504s Main  Caused by: junit.framework.AssertionFailedError: expected:<true> but was:<false>
C  178.504s Main  	at org.chromium.net.CronetUrlRequestTest.throwOrCancel(CronetUrlRequestTest.java:1689)
C  178.504s Main  	at org.chromium.net.CronetUrlRequestTest.testFailures(CronetUrlRequestTest.java:1720)
C  178.504s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  178.504s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:134)
C  178.504s Main  	... 9 more

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/3314

 
C  154.205s Main  [FAIL] org.chromium.net.CronetUrlRequestTest#testFailures:
C  154.205s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  154.205s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:148)
C  154.205s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  154.205s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  154.206s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  154.206s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  154.206s Main  Caused by: junit.framework.AssertionFailedError: expected:<true> but was:<false>
C  154.206s Main  	at org.chromium.net.CronetUrlRequestTest.throwOrCancel(CronetUrlRequestTest.java:1682)
C  154.206s Main  	at org.chromium.net.CronetUrlRequestTest.testFailures(CronetUrlRequestTest.java:1713)
C  154.206s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  154.206s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:145)
C  154.206s Main  	... 9 more
C  154.206s Main  ********************************************************************************
C  154.206s Main  Summary
C  154.206s Main  ********************************************************************************
C  154.208s Main  [==========] 297 tests ran.
C  154.208s Main  [  PASSED  ] 296 tests.
C  154.208s Main  [  FAILED  ] 1 test, listed below:
C  154.208s Main  [  FAILED  ] org.chromium.net.CronetUrlRequestTest#testFailures
C  154.208s Main  

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/3705/steps/cronet_test_instrumentation_apk/logs/stdio

Here's one that affects the Java implementation
Owner: xunji...@chromium.org
Status: Started (was: Untriaged)
Alright, I see what's wrong. I will upload a CL shortly.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/674e1123ddf931517378009e6cbd0705209a6edd

commit 674e1123ddf931517378009e6cbd0705209a6edd
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Dec 14 16:07:24 2016

Fix CronetUrlRequestTest#testFailures flake

When CronetUrlRequest is canceled asynchronously in a callback without
being paused, we might already have a onSucceeded() callback in the
executor's queue. If that is the case, we won't have a onCanceled()
callback. This led to test flake. This CL adjusts the test expectation
and adds a comment.

R=pauljensen@chromium.org

BUG= 657415 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2572693003
Cr-Commit-Position: refs/heads/master@{#438526}

[modify] https://crrev.com/674e1123ddf931517378009e6cbd0705209a6edd/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Status: Fixed (was: Started)

Sign in to add a comment