CronetUrlRequestTest#testFailures flake |
||||
Issue descriptionDifferent from the one before. This one affects the native implementation. C 178.503s Main [FAIL] org.chromium.net.CronetUrlRequestTest#testFailures: C 178.503s Main java.lang.Throwable: CronetTestBase#runTest failed. C 178.503s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137) C 178.503s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 178.503s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 178.503s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 178.503s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) C 178.504s Main Caused by: junit.framework.AssertionFailedError: expected:<true> but was:<false> C 178.504s Main at org.chromium.net.CronetUrlRequestTest.throwOrCancel(CronetUrlRequestTest.java:1689) C 178.504s Main at org.chromium.net.CronetUrlRequestTest.testFailures(CronetUrlRequestTest.java:1720) C 178.504s Main at java.lang.reflect.Method.invokeNative(Native Method) C 178.504s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:134) C 178.504s Main ... 9 more https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/3314
,
Dec 13 2016
In both cases, the failed test is
throwOrCancel(FailureType.CANCEL_ASYNC_WITHOUT_PAUSE, ResponseStep.ON_READ_COMPLETED,
true, false);
Code for #1 is at https://chromium.googlesource.com/chromium/src/+/ee185e31223c53d9c0e2a24ef1603b84acf9f708/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
Code for #2 is at
https://chromium.googlesource.com/chromium/src/+/e4c4ef93035599e45622cdd54753047219eccf0f/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
,
Dec 13 2016
Alright, I see what's wrong. I will upload a CL shortly.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/674e1123ddf931517378009e6cbd0705209a6edd commit 674e1123ddf931517378009e6cbd0705209a6edd Author: xunjieli <xunjieli@chromium.org> Date: Wed Dec 14 16:07:24 2016 Fix CronetUrlRequestTest#testFailures flake When CronetUrlRequest is canceled asynchronously in a callback without being paused, we might already have a onSucceeded() callback in the executor's queue. If that is the case, we won't have a onCanceled() callback. This led to test flake. This CL adjusts the test expectation and adds a comment. R=pauljensen@chromium.org BUG= 657415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2572693003 Cr-Commit-Position: refs/heads/master@{#438526} [modify] https://crrev.com/674e1123ddf931517378009e6cbd0705209a6edd/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
,
Dec 14 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xunji...@chromium.org
, Dec 13 2016