Flaky SdchTest#testSdchEnabled |
|||
Issue descriptionJava stderr from crashing pid (may identify underlying Java exception): java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.ConditionVariable.open()' on a null object reference at org.chromium.net.SdchTest$DictionaryAddedObserver.onDictionaryAdded(SdchTest.java:157) https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/2942
,
Feb 16 2017
Andrei and I have looked at it and it appears to be caused by SdchObserver constructor calling nativeAddSdchObserver so it is added to the native list of observers before being fully constructed, and getting onDictionaryAdded callback from the network thread before DictionaryAddedObserver has finished construction and created mBlock variable.
,
Feb 21 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c commit 5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c Author: kapishnikov <kapishnikov@chromium.org> Date: Wed Feb 22 01:26:50 2017 Fix of flaky SdchTest#testSdchEnabled test. BUG= 657413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2709003002 Cr-Commit-Position: refs/heads/master@{#451872} [modify] https://crrev.com/5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c/components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java [modify] https://crrev.com/5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c/components/cronet/android/test/src/org/chromium/net/SdchObserver.java
,
Feb 22 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mef@chromium.org
, Feb 16 2017