New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657366 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Count of deleted images is not seen in Delete Overlay

Project Member Reported by mmanchala@chromium.org, Oct 19 2016

Issue description

Version: 54.0.2840.67/8743.68.0 Daisy,peepy and Blaze
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Launch Camera App -> Take more number of images(Ex: 15)
(2)Now Go to Camera Gallery -> Select all images using Ctrl+A -> Click on 'Delete' icon
(3)Now observe for Count of deleted images in Delete Overlay(Please refer screenshot)

Expected: Number of deleted images count should be seen in Delete Overlay
Actual: Instead Count of deleted images is not seen

This is Non-Regression issue seen from M-38

Note: In Files App Count of deleted images is seen in Delete Overlay

@yuli: Please confirm the issue

 
Actual_Message.png
339 KB View Download
Expected_Number.jpg
132 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae

commit cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae
Author: Yuli Huang <yuli@chromium.org>
Date: Thu Feb 01 04:27:40 2018

Improve the delete-confirmation messages.

BUG= chromium:657366 
TEST=Tested manually on elm.

Change-Id: I878a04f1e3a809c68bae2b3b50c130e51eb88fca
Reviewed-on: https://chromium-review.googlesource.com/895163
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae/src/_locales/en/messages.json
[modify] https://crrev.com/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae/src/js/views/gallery_base.js

Comment 2 by y...@chromium.org, Feb 1 2018

Cc: shenghao@chromium.org
Status: Fixed (was: Assigned)
Please verify it on the next camera app canary.
Status: Assigned (was: Fixed)
Issue is still seen on 66.0.3355.0/10442.0.0 dev-channel Reks. Hence Reopening this issue and attaching video for reference

Thanks..!!
Actual_BehaviorOnLatextM66Build.webm
1.0 MB View Download

Comment 4 by y...@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)
We have not yet released the updated camera app; shenghao@ will send out the new binary later. Please verify it on the next camera app canary.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae

commit cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae
Author: Yuli Huang <yuli@chromium.org>
Date: Thu Feb 01 04:27:40 2018

Improve the delete-confirmation messages.

BUG= chromium:657366 
TEST=Tested manually on elm.

Change-Id: I878a04f1e3a809c68bae2b3b50c130e51eb88fca
Reviewed-on: https://chromium-review.googlesource.com/895163
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae/src/_locales/en/messages.json
[modify] https://crrev.com/cfeb2b957809d7fcf1fac0f8d1eb177a50f2a1ae/src/js/views/gallery_base.js

Project Member

Comment 6 by bugdroid, Today (8 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a9aa16f2543fc651e9d5ecb94d0e943659e161

commit e4a9aa16f2543fc651e9d5ecb94d0e943659e161
Author: Yuli Huang <yuli@chromium.org>
Date: Thu Feb 01 04:27:40 2018

Improve the delete-confirmation messages.

BUG= chromium:657366 
TEST=Tested manually on elm.

Change-Id: I878a04f1e3a809c68bae2b3b50c130e51eb88fca
Reviewed-on: https://chromium-review.googlesource.com/895163
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>


Sign in to add a comment