New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657357 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Oct 2016
Cc:
calamity@chromium.org
nyerramilli@chromium.org
dbeam@chromium.org
█ tkonch...@chromium.org
█ tsergeant@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

'You can clear your browsing data from this menu' tool-tip does not vanish after dragging side Drawer of chrome://history.

Reported by jshan...@etouch.net, Oct 19 2016 
Chrome Version: 56.0.2895.0 d9d3ea15202868716617ceb73ee8d5595778d504-refs/heads/master@{#426105} (32/64 bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

Steps:
1. Freshly launch Chrome and navigate to chrome://history
2. Resize the browser window such that 'Main menu' icon and 'You can clear your browsing data from this menu' is seen.
3. Now drag the side Drawer and observe.

Actual: 'You can clear your browsing data from this menu' tool-tip does not vanish after dragging side Drawer.

Expected: 'You can clear your browsing data from this menu' tool-tip should vanish after dragging side Drawer.

This is non-regression issue seen from M-55, since this is new feature introduced in 55.0.2868.0

Changelog url:
https://chromium.googlesource.com/chromium/src/+log/55.0.2867.0..55.0.2868.0?pretty=fuller&n=10000

Suspecting: r420095?

@dbeam, can you take a look please?
Actual_video.mp4
303 KB View Download
Actual_result.jpg
139 KB View Download

Comment 1 by tkonch...@chromium.org, Oct 19 2016

Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on mac 10.11.6 chrome version 56.0.2895.0

Comment 2 by dbeam@chromium.org, Oct 25 2016

Owner: dbeam@chromium.org
Status: Started (was: Untriaged)

Comment 3 by dbeam@chromium.org, Oct 25 2016

Cc: calamity@chromium.org tsergeant@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4c0fe97a41412df82df5a4b082270fef8df0f28

commit e4c0fe97a41412df82df5a4b082270fef8df0f28
Author: dbeam <dbeam@chromium.org>
Date: Thu Oct 27 18:38:43 2016

MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG= 657357 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2450663003
Cr-Commit-Position: refs/heads/master@{#428089}

[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Comment 5 by dbeam@chromium.org, Oct 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment