New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657340 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Flickering of 'delete' button is seen after pressing shift+tab key for first instance.

Reported by vku...@etouch.net, Oct 19 2016

Issue description

Chrome Version:54.0.2840.68 (Official Build)Revision e5934e0f324e72f35dac7868c9b554a4295b2ceb-refs/branch-heads/2840@{#755} (32/64-bit)
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
(1)Freshly launch chrome and open 2-3 webpages
(2)Navigate to chrome://history/ , click on any entry.
(3)Press shift+tab key to navigate back and observe "Delete" button.

Actual: Flickering of 'delete' button is seen after pressing shift+tab key for first instance.

Expected: No such flickering of 'delete' button should be seen after pressing shift+tab key.

This is a regression issue broken in 'M54' and below is the manual regression range:
Good Build: 54.0.2811.0 
Bad Build:  54.0.2812.0 


 
Actual_res.mov
1011 KB Download
Expected_res.mov
682 KB Download
Status: Untriaged (was: Unconfirmed)
Working on bisect. will provide the info soon
Labels: Needs-Bisect
Labels: -Needs-Bisect
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 54.0.2811.0 (Revision: 408553).
Bad build: 54.0.2812.0 (Revision: 408751).

You are probably looking for a change made after 408571 (known good), but no later than 408572 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/4dab74137593abb0888e415294aeb80da27362e3..5844d81e3382eaabda8f366eafb424050a47ec52

@tsergeant -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Labels: -Pri-1 Pri-3
Similar to  issue 648522  in downloads.

We can fix this with 

`document.fonts.load("bold 12px Roboto");` at an appropriate place.
Labels: Proj-MaterialDesign-WebUI
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505f6aaa36d0ff74761022409da1534c6f0d00d1

commit 505f6aaa36d0ff74761022409da1534c6f0d00d1
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Nov 18 03:45:08 2016

MD History: Preload bold Roboto font

This prevents flickering when the font is first displayed.

BUG= 657340 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509593007
Cr-Commit-Position: refs/heads/master@{#433071}

[modify] https://crrev.com/505f6aaa36d0ff74761022409da1534c6f0d00d1/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/505f6aaa36d0ff74761022409da1534c6f0d00d1/chrome/browser/resources/md_history/app.js

Status: Fixed (was: Started)
Labels: Merge-Request-56
Verified in latest canary (57.0.2926.0)

Requesting merge back to M56.

Comment 10 by dimu@chromium.org, Nov 20 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 20 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c33f9c3960ecc371bdecb879e7da574c10b501

commit 63c33f9c3960ecc371bdecb879e7da574c10b501
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Sun Nov 20 23:10:51 2016

MD History: Preload bold Roboto font

This prevents flickering when the font is first displayed.

BUG= 657340 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509593007
Cr-Commit-Position: refs/heads/master@{#433071}
(cherry picked from commit 505f6aaa36d0ff74761022409da1534c6f0d00d1)

Review URL: https://codereview.chromium.org/2520763002 .

Cr-Commit-Position: refs/branch-heads/2924@{#14}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/63c33f9c3960ecc371bdecb879e7da574c10b501/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/63c33f9c3960ecc371bdecb879e7da574c10b501/chrome/browser/resources/md_history/app.js

Sign in to add a comment