Issue metadata
Sign in to add a comment
|
FindRequestManagerTest failing on 3 builders |
||||||||||||||||||||||
Issue descriptioncontent_browsertests failing on 2 builders Type: build-failure Builders failed on: - Lollipop Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester - Marshmallow Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester - Lollipop Low-end Tester: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester All of the following tests have been failing often on recent builds: FindRequestManagerTest.ActivateNearestFindMatch FindRequestManagerTest.AddFrameAfterNoMatches FindRequestManagerTest.FindInPage_Issue627799 FindRequestManagerTest.FindInPage_Issue644448 FindRequestManagerTest.FindMatchRects FindRequestManagerTest.HiddenFrame FindRequestManagerTests/FindRequestManagerTest.AddFrame/0 FindRequestManagerTests/FindRequestManagerTest.Basic/0 FindRequestManagerTests/FindRequestManagerTest.CharacterByCharacter/0 FindRequestManagerTests/FindRequestManagerTest.FindNewMatches/0 FindRequestManagerTests/FindRequestManagerTest.NavigateFrame/0 FindRequestManagerTests/FindRequestManagerTest.RapidFire/0 FindRequestManagerTests/FindRequestManagerTest.RemoveFrame/0
,
Oct 19 2016
+paulmeyer who has written most of content/browser/find_request_manager_browsertest.cc
,
Oct 19 2016
It appears that the failures started on the following builds: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/5314 https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/5889 With the following small overlapping CL range: http://test-results.appspot.com/revision_range?start=425255&end=425258
,
Oct 20 2016
Tests still failing, should they be disabled?
,
Oct 20 2016
The tests should definitely not be disabled, since they have not changed recently and there is nothing wrong with them. It seems like someone has broken something recently that is making the tests fail, so I think the problem CL should be found and reverted.
,
Oct 25 2016
This has been broken for a week now; are you investigating Paul? Can you find a different owner if not? We can't leave these tests flaking this long; they'll have to be disabled for android. The revision range identified in #3 doesn't seem plausible unfortunately: the tests are not failing 100% of the time (just more than 50%), so it's possible the culprit change is earlier. :/
,
Oct 25 2016
Actually this appears to be a dupe of issue 615291 - the tests were disabled on android for release only, but it seems likely the issue is not related to debug vs release. I'm going to dupe this and extend the disabling to debug.
,
Oct 25 2016
Actually this isn't a duplicate of issue 615291. That issue has to do with a specific DCHECK that was failing, and was only reproducible on the one (Release) trybot. These tests have all passed fine on Android Debug since June, so this is a very new and completely separate issue.
,
Oct 25 2016
#3: That CL range seems to not cover the offending CL.
,
Oct 25 2016
,
Oct 25 2016
Yeah, since the test is not failing 100% of the time it's probable that the culprit CL was somewhat earlier and it just didn't happen to fail in the first build that included it on every bot. I looked at the CLs in a few earlier builds and didn't see a reasonable suspect unfortunately :/
,
Nov 28 2016
These tests are still regularly failing on multiple bots (and not just android; also mac, linux and windows bots), so I am going to go ahead and disable them.
,
Nov 28 2016
(maybe the issue effecting other platforms is a different bug, not sure. Only disabled AddFrame and RemoveFrame, as those seem to be the only truly flaky ones).
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9843095b0c1e95f529bdc0db8f6a75d6215c6fa7 commit 9843095b0c1e95f529bdc0db8f6a75d6215c6fa7 Author: mek <mek@chromium.org> Date: Tue Nov 29 01:34:46 2016 Disable FindRequestManagerTest.AddFrame and RemoveFrame. These tests frequently fail on various builders, so disabling them. BUG= 657331 TBR=paulmeyer@chromium.org Review-Url: https://codereview.chromium.org/2539603002 Cr-Commit-Position: refs/heads/master@{#434814} [modify] https://crrev.com/9843095b0c1e95f529bdc0db8f6a75d6215c6fa7/content/browser/find_request_manager_browsertest.cc
,
Dec 5 2016
Not seeing this testing failures on Windows, mac and linux trunk builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/51974 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/42948 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20trunk/builds/20482 Removing bisect label.
,
May 2 2017
,
Oct 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by perezju@chromium.org
, Oct 19 2016