Serialized WASM modules should store only one copy of the module bytes |
|||
Issue descriptionV8 supports serializing a compiled WebAssembly module to storage. Currently, serialization stores potentially two copies of the original module bytes.
,
Oct 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/91a5a219d46d592b49f6e963d308b2bbdc9b5b60 commit 91a5a219d46d592b49f6e963d308b2bbdc9b5b60 Author: mtrofin <mtrofin@chromium.org> Date: Sat Oct 22 15:14:40 2016 [wasm] Avoid double-serializing the wire bytes Since the public API for deserialization is now just DeserializeOrCompile, we can trickle down the wire bytes to the deserialization logic, and avoid the need for duplicating the wire bytes when serializing. BUG= chromium:657316 Review-Url: https://chromiumcodereview.appspot.com/2433273002 Cr-Commit-Position: refs/heads/master@{#40516} [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/include/v8.h [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/api.cc [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/heap/heap.h [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/runtime/runtime-test.cc [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/runtime/runtime.h [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/snapshot/code-serializer.cc [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/src/snapshot/code-serializer.h [modify] https://crrev.com/91a5a219d46d592b49f6e963d308b2bbdc9b5b60/test/mjsunit/wasm/compiled-module-serialization.js
,
May 29 2017
Mircea, is this fixed?
,
May 29 2017
Oh, yes. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 19 2016