New issue
Advanced search Search tips

Issue 657294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 697243


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

MacViews Shiny Modern Page Info dropdowns use long strings for display values

Project Member Reported by lgar...@chromium.org, Oct 19 2016

Issue description

Chrome 56.0.2895.0
OSX 10.11.6

What steps will reproduce the problem?
(1) Enable Harmony
(2) Open Page Info and click on a permission.

What is the expected output?
The displayed values are short (e.g. "Ask (default)"), while the dropdown listings show long descriptions (e.g. "Use global default (Allow)").
See mac-native.png and windows-not-harmony.png .

What do you see instead?
The long descriptions are used for display values.
See mac-views-shiny-modern.png .

This isn't critical now that the Googler MacViews experiment is off, but this should ideally be fixed before turning it back on.

See  Issue 657292  for a sister Harmony bug, but note that non-Harmony non-Mac Views does not have this problem.
 
mac-native.png
209 KB View Download
windows-not-harmony.png
143 KB View Download
mac-views-shiny-modern.png
201 KB View Download
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73895a611399a7ed15be3b89c7dedc8cb2a3c7f6

commit 73895a611399a7ed15be3b89c7dedc8cb2a3c7f6
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Feb 28 21:49:19 2017

views: use shorter menu strings in Harmony website settings

The website settings dialog is supposed to use shorter strings
in Harmony mode.

BUG= 657294 

Review-Url: https://codereview.chromium.org/2715233004
Cr-Commit-Position: refs/heads/master@{#453710}

[modify] https://crrev.com/73895a611399a7ed15be3b89c7dedc8cb2a3c7f6/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/73895a611399a7ed15be3b89c7dedc8cb2a3c7f6/chrome/browser/ui/website_settings/permission_menu_model.cc

Blocking: 697243
Status: Fixed (was: Available)
Seems to be fixed.

Sign in to add a comment