Harmony: Page Info dropdowns use long strings for display values |
|||
Issue descriptionChrome 56.0.2895.0 OSX 10.11.6 What steps will reproduce the problem? (1) Enable Harmony (2) Open Page Info and click on a permission. What is the expected output? The displayed values are short (e.g. "Ask (default)"), while the dropdown listings show long descriptions (e.g. "Use global default (Allow)"). See windows-not-harmony.png . What do you see instead? The long descriptions are used for display values. See windows-harmony.png and mac-views-harmony.png .
,
Feb 28 2017
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b0f801fa697ed48e8c2b7f1c0cd1407cacdd783 commit 4b0f801fa697ed48e8c2b7f1c0cd1407cacdd783 Author: patricialor <patricialor@chromium.org> Date: Wed Mar 08 23:08:38 2017 Views/Permissions: Use shorter strings for site setting drop downs. Drop-downs in the OIB typically show three options for each site setting - ask, allow, and block. For Harmony, shorter strings should be used in these drop downs. r453710 partly implemented the use of short strings for settings that were set to the default, but it also introduced a bug where it would show the incorrect string in place of the default option when there was a non-default option selected. (For example, when set to 'Allow', the default option that usually says 'Ask' would also say 'Allow', resulting in two 'Allow' options - one using the long string and one using the short.) Fix this bug and also start using short strings for all other site setting options. BUG= 657292 Review-Url: https://codereview.chromium.org/2732963005 Cr-Commit-Position: refs/heads/master@{#455580} [modify] https://crrev.com/4b0f801fa697ed48e8c2b7f1c0cd1407cacdd783/chrome/browser/ui/website_settings/permission_menu_model.cc [modify] https://crrev.com/4b0f801fa697ed48e8c2b7f1c0cd1407cacdd783/chrome/browser/ui/website_settings/website_settings_ui.h
,
Mar 13 2017
Forgot to post this last week - this is a screenshot of what it looks like now (on Mac Harmony). Marking this as fixed now because it looks like non-Mac Harmony already has this implemented. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lafo...@chromium.org
, Oct 20 2016