I think the right click on this menu is platform dependent. On what OS have you experienced this bug?

I'm seeing right-click-is-broken on Linux because that's the only platform I'm running dev channel on. I've used right-click on Mac/Windows/Linux in the past so it's something that at least traditionally was supported on all our desktop platforms.

+anthonyvd/ewald since I think this is their baby.

+UX

Removing right-click was intentional. The purpose of the right-click was to allow users to quickly switch profiles with only two clicks. However, in the new version of the user menu, you can switch profiles directly inline from the regular (left-click) menu as well (which also only takes two clicks). There's no reason to have the duplicated functionality.

However, it's definitely a bug if the menu is staying open after clicking outside of it. Can you confirm that you're able to repro that on Linux consistently? Any repro steps other than "left-click the user menu, left-click outside the menu"? I'm unable to repro it on Mac.

Re: removing right-click. I would agree if we were launching this feature in a vacuum. But we're changing the UX for an already-launched feature, so it seems nice to maintain the old UX as well since it seems trivial. Clearly, this is UX's call, but removing the old right-click behavior does not seem intended to delight users.

And yes, I am able to repro on linux consistently (at least I did yesterday).

> Able to repro on linux consistently

anthonyvd, can you please look into this? I imagine if it's an issue on Linux, it might be an issue on Windows as well. We need to make sure that clicking outside the user menu dismisses it.

> Right-click

As a general principle, I don't think we should feel obligated to carry around certain behaviors or UI if we replace the functionality elsewhere. If we never deprecated UI that was no longer needed, things could quickly become quite cluttered and repetitive.

I defer to UX, though. cleer/bettes (cc'ed) - what are your opinions?

I agree with removing right click since the behavior is now incorporated into left click, for the same reason stated in comment #6. We might consider a more staggered deprecation strategy if the new behavior were significantly difficult to discover from using the old behavior, but it's left click.

OK, looked at this more. Turns out that the repro is:

1) Click on Profile Chooser button
2) Menu pops up
3) Move mouse to the left so it is no longer on the profile chooser button, but is instead on the header of the window (see screenshot)
4) Click.

Expected: menu closes (as happens with the hotdog menu)
Actual: menu doesn't close, instead you get a little hand to move the window

Clicking elsewhere closes the menu, just not if you click in the header of the browser window.

I suspect this is linux only.

Deleted: Selection_139.png 12.2 KB

	Selection_139.png 12.2 KB View Download

 Issue 660728  has been merged into this issue.

> As a general principle, I don't think we should feel obligated to carry around certain behaviors or UI if we replace the functionality elsewhere.

As a general principle, I agree. But I think we should weigh annoyance factor with cost to support. What would it cost us to continue supporting right-click? I would imagine implementation costs + long term maintenance costs are very low. In exchange we don't disrupt or annoy any users.

> If we never deprecated UI that was no longer needed, things could quickly become quite cluttered and repetitive.

True, but I don't think this applies to this scenario. I think the same UI would appear on both left and right clicks, so I don't think we're at risk for either repetition or clutter.

> What would it cost us to continue supporting right-click?

Just additional code and UX complexity. The UI is actually a little different from the list in left-click, so it wouldn't just be the same codepath.

I agree the maintenance cost would be relatively low, but it'd still be non-zero.

It's also important to remember that the fallback is left-click. It's not hard to discover. I imagine that the small number of power-users that use this feature will quickly discover that the same functionality is now available via left-click. As Chris said, I'd be more inclined to have a gradual deprecation strategy if the functionality were about to become a lot more hidden.

Re: menu not being dismissed. This has been tracked in Issue 450461 for a while and we haven't gotten around to investigating it.

Bouncing back to ewald@ for the discussion about right-click being removed.

OK, refocusing the bug title.

I discussed offline with zkoch. I misunderstood his suggestion (and possibly atwilson's as well - sorry if I did!)

The suggestion is to make right-click bring up the same menu that we bring up on left-click (instead of bringing up either nothing or the old right-click menu that just has the profiles). The rationale is that it's no extra UI, probably only one extra line of code to make right-click also bring up the menu, and doesn't break existing user flows. It also trains people that right-clicking will now bring up the same menu as left-click, so if we want to repurpose right-click in the future for something else, users will have already learned that left-click does the same thing now.

This actually seems pretty reasonable to me. Chris - what do you think?

(Bouncing it over to Chris to answer the question, feel free to bounce back)

Chatted about this offline with Chris and Anthony. We're on board with having right-click bring up the same user menu as left-click for a couple milestones to allow users time to learn the new behavior.

We will deprecate right click in M57.

Anthony, assigning to you and marking as M55 so we can re-add the right-click behavior for the user menu rollout. To be clear, we should bring up the regular user menu, not just the list of accounts.

Yay! Thanks, all!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b24b79eb930b4abb10451a77489528325a8bd63

commit 6b24b79eb930b4abb10451a77489528325a8bd63
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Nov 07 20:33:35 2016

Show user menu on right-click of the avatar button when MaterialDesignUserMenu is enabled.

BUG= 657291 

Review-Url: https://codereview.chromium.org/2478523003
Cr-Commit-Position: refs/heads/master@{#430360}

[modify] https://crrev.com/6b24b79eb930b4abb10451a77489528325a8bd63/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/6b24b79eb930b4abb10451a77489528325a8bd63/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4a363490639dd75eb6529f6ca1e5e728cd1af2

commit fb4a363490639dd75eb6529f6ca1e5e728cd1af2
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed Nov 09 18:28:03 2016

[Merge] Show user menu on right-click of the avatar button when MaterialDesignUserMenu is enabled.

BUG= 657291 

Review-Url: https://codereview.chromium.org/2478523003
Cr-Commit-Position: refs/heads/master@{#430360}
(cherry picked from commit 6b24b79eb930b4abb10451a77489528325a8bd63)

Review URL: https://codereview.chromium.org/2491603002 .

Cr-Commit-Position: refs/branch-heads/2883@{#508}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/fb4a363490639dd75eb6529f6ca1e5e728cd1af2/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/fb4a363490639dd75eb6529f6ca1e5e728cd1af2/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Tested the fix on Ubuntu 14.04 using Chrome Beta version #55.0.2883.52 as per the below steps

1) Right Click on Profile Chooser button
2) Menu pops up
3) Move mouse to the left so it is no longer on the profile chooser button, but is instead on the header of the window 
4) Click on the header of the window 
5) Observed that it is not closing the popup window

In case of windows and mac OS, if we click anywhere in the header of the window it closing the popup window.
Seeing this issue still on Linux

 ewald@ Could you please look into the attached screeencast and confirm on fix.

Deleted: Issue 657291.webm 1.8 MB

	Issue 657291.webm 1.8 MB View Download

Thanks kkaluri@! The issue with the menu not closing is being tracked in Issue 450461. This issue was focused on adding the ability to right-click the button and have the menu appear. Looks like you've verified that fix.

As per comment #26, Adding TE verified labels

Issue 657169 has been merged into this issue.