New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657283 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 660735
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DevRel-SAP: (Regression) Text isn't displayed correctly after hiding and changing the text

Reported by orit.ha...@sap.com, Oct 19 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:
1.Open http://jsbin.com/dehiwecava/1/edit?html,js,output
2.Click “Make text hidden” button
3.Click “Change text and make it visible” button

2. 
3. 

What is the expected behavior?
The displayed text should be “New Text”

What went wrong?
The displayed text is “Old Text”

Did this work before? Yes Chrome version 53.0.2785.143

Chrome version: 54.0.2840.59  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

- When clicking only on “Change text and make it visible” button, the text is changed correctly.
- Works fine in IE11

Chrome version: 54.0.2840.59
Works fine in IE11.
 
Labels: Needs-Bisect

Comment 2 by hdodda@chromium.org, Oct 20 2016

Cc: hdodda@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: sashab@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:54.0.2836.0 (Revision: 413363).
Bad build: 54.0.2837. 0 (Revision: 413618).

You are probably looking for a change made after 413405 (known good), but no later than 413406 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 
https://chromium.googlesource.com/chromium/src/+log/bfd1b37e43efa00f282a93a2d8e4bb1bb210eccd..d0c57905368c76aba662dbda3b4e13cb9bd454bf

From the CL above, suspecting the below change 

@sashab - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2220873002

Thanks !

Comment 3 by sashab@chromium.org, Nov 10 2016

This should be fixed by https://codereview.chromium.org/2492783002/. Will work on merging this into stable.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998f4790884a34c5ac5167876a13b7cb7495a617

commit 998f4790884a34c5ac5167876a13b7cb7495a617
Author: rune <rune@opera.com>
Date: Fri Nov 11 00:50:20 2016

Skip independent inherited property propagation to pseudo elements.

UpdatePseudoElements and IndependentInherit conflict in the following
way. If we both have an independent inherit change on the actual dom
element, and we detect that we need to update the style for the pseudo
element we need to signal the inheritance propagation to the real dom
children and signal the pseudo element recalc to the pseudo element
children. If we return IndependentInherit, we lose the information
about the need for a pseudo element recalc, and if we return
UpdatePseudoElement, we lose the inheritance propagation for the actual
dom children.

We could introduce a new IndependentInheritAndUpdatePseudoElements, but
if there exists pseudo element, we would always return this constant,
so instead just force recalc on pseudo elements on IndependentInherit.

R=sashab@chromium.org
BUG= 660735 , 660089 , 657283 

Review-Url: https://codereview.chromium.org/2492783002
Cr-Commit-Position: refs/heads/master@{#431430}

[add] https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617/third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html
[modify] https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617/third_party/WebKit/Source/core/dom/Element.cpp

Comment 5 by sashab@chromium.org, Nov 14 2016

Mergedinto: 660735
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbebf3ba3a5b8ff0a645d026a0ede213135521d

commit 9bbebf3ba3a5b8ff0a645d026a0ede213135521d
Author: Rune Lillesveen <rune@opera.com>
Date: Thu Nov 17 10:53:20 2016

Skip independent inherited property propagation to pseudo elements.

UpdatePseudoElements and IndependentInherit conflict in the following
way. If we both have an independent inherit change on the actual dom
element, and we detect that we need to update the style for the pseudo
element we need to signal the inheritance propagation to the real dom
children and signal the pseudo element recalc to the pseudo element
children. If we return IndependentInherit, we lose the information
about the need for a pseudo element recalc, and if we return
UpdatePseudoElement, we lose the inheritance propagation for the actual
dom children.

We could introduce a new IndependentInheritAndUpdatePseudoElements, but
if there exists pseudo element, we would always return this constant,
so instead just force recalc on pseudo elements on IndependentInherit.

R=sashab@chromium.org
BUG= 660735 , 660089 , 657283 

Review-Url: https://codereview.chromium.org/2492783002
Cr-Commit-Position: refs/heads/master@{#431430}
(cherry picked from commit 998f4790884a34c5ac5167876a13b7cb7495a617)

Review URL: https://codereview.chromium.org/2511073002 .

Cr-Commit-Position: refs/branch-heads/2883@{#598}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/9bbebf3ba3a5b8ff0a645d026a0ede213135521d/third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html
[modify] https://crrev.com/9bbebf3ba3a5b8ff0a645d026a0ede213135521d/third_party/WebKit/Source/core/dom/Element.cpp

Labels: TE-Verified-55.0.2883.59 TE-Verified-M55
Verified the fix on Windows 10 using Chrome Beta version #55.0.2883.59 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screencast for reference

Hence, adding the TE-verified labels
Issue 657283.mp4
1.2 MB View Download

Sign in to add a comment